From e4323602fec4bdb00c58a882ba9fb7735ddb106d Mon Sep 17 00:00:00 2001 From: Maria-Bordunova Date: Wed, 16 Feb 2022 17:52:34 +0300 Subject: [PATCH 1/4] Update native iOS dependency version --- ios/qonversion_flutter.podspec | 2 +- macos/qonversion_flutter.podspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ios/qonversion_flutter.podspec b/ios/qonversion_flutter.podspec index fe3d667b..2968395e 100644 --- a/ios/qonversion_flutter.podspec +++ b/ios/qonversion_flutter.podspec @@ -16,7 +16,7 @@ Pod::Spec.new do |s| s.source_files = 'Classes/**/*' s.dependency 'Flutter' s.platform = :ios, '9.0' - s.dependency 'Qonversion', '2.18.0' + s.dependency 'Qonversion', '2.18.2' # Flutter.framework does not contain a i386 slice. Only x86_64 simulators are supported. s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' } diff --git a/macos/qonversion_flutter.podspec b/macos/qonversion_flutter.podspec index 925113c6..311a7cba 100644 --- a/macos/qonversion_flutter.podspec +++ b/macos/qonversion_flutter.podspec @@ -16,7 +16,7 @@ Pod::Spec.new do |s| s.source_files = 'Classes/**/*' s.dependency 'FlutterMacOS' s.platform = :osx, '10.12' - s.dependency 'Qonversion', '2.18.0' + s.dependency 'Qonversion', '2.18.2' s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } s.swift_version = '5.0' s.static_framework = true From bce0c63995cf9ca390a77158c26a867daab7704c Mon Sep 17 00:00:00 2001 From: Maria-Bordunova Date: Wed, 16 Feb 2022 19:30:52 +0300 Subject: [PATCH 2/4] Fix for Android v2 embedding (sample app) --- example/android/app/src/main/AndroidManifest.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/example/android/app/src/main/AndroidManifest.xml b/example/android/app/src/main/AndroidManifest.xml index b0b5a1ec..e04a4f83 100644 --- a/example/android/app/src/main/AndroidManifest.xml +++ b/example/android/app/src/main/AndroidManifest.xml @@ -10,7 +10,6 @@ Date: Thu, 17 Feb 2022 19:40:33 +0300 Subject: [PATCH 3/4] Update native iOS dependency to 2.18.3 --- ios/qonversion_flutter.podspec | 2 +- macos/qonversion_flutter.podspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ios/qonversion_flutter.podspec b/ios/qonversion_flutter.podspec index 2968395e..f890ff2e 100644 --- a/ios/qonversion_flutter.podspec +++ b/ios/qonversion_flutter.podspec @@ -16,7 +16,7 @@ Pod::Spec.new do |s| s.source_files = 'Classes/**/*' s.dependency 'Flutter' s.platform = :ios, '9.0' - s.dependency 'Qonversion', '2.18.2' + s.dependency 'Qonversion', '2.18.3' # Flutter.framework does not contain a i386 slice. Only x86_64 simulators are supported. s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' } diff --git a/macos/qonversion_flutter.podspec b/macos/qonversion_flutter.podspec index 311a7cba..79e18ac7 100644 --- a/macos/qonversion_flutter.podspec +++ b/macos/qonversion_flutter.podspec @@ -16,7 +16,7 @@ Pod::Spec.new do |s| s.source_files = 'Classes/**/*' s.dependency 'FlutterMacOS' s.platform = :osx, '10.12' - s.dependency 'Qonversion', '2.18.2' + s.dependency 'Qonversion', '2.18.3' s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } s.swift_version = '5.0' s.static_framework = true From 1a8c083238d8e4d8b05169c671d5699dc370dc6e Mon Sep 17 00:00:00 2001 From: Maria-Bordunova Date: Mon, 21 Feb 2022 14:42:07 +0300 Subject: [PATCH 4/4] Apply suggestions from code review --- lib/src/qonversion.dart | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/src/qonversion.dart b/lib/src/qonversion.dart index 6b85afec..6878aea7 100644 --- a/lib/src/qonversion.dart +++ b/lib/src/qonversion.dart @@ -296,11 +296,12 @@ class Qonversion { /// Enable attribution collection from Apple Search Ads. NO by default. static Future setAppleSearchAdsAttributionEnabled(bool enable) async { - if (Platform.isIOS) { - return _channel.invokeMethod( - Constants.mSetAppleSearchAdsAttributionEnabled, - {Constants.kEnableAppleSearchAdsAttribution: enable}); + if (!Platform.isIOS) { + return null; } + + return _channel.invokeMethod(Constants.mSetAppleSearchAdsAttributionEnabled, + {Constants.kEnableAppleSearchAdsAttribution: enable}); } /// Set push token to Qonversion to enable Qonversion push notifications