Skip to content

Role is missing #8

Closed
brendon opened this Issue Apr 3, 2013 · 4 comments

2 participants

@brendon
brendon commented Apr 3, 2013

Hi there, for some reason the Role attribute is missing as something that can be set. Is this the place to request that it be added in?

@qoobaa
Owner
qoobaa commented Apr 3, 2013

Sure. Give me a PR, I'll merge it.

@brendon
brendon commented Apr 3, 2013

Cool. I managed to get around it by adding the field manually

maker.add_field ::Vcard::DirectoryInfo::Field.create('ROLE', ::Vcard.encode_text(@contact.role))

But if you'd still like the pull request let me know. Do you need tests with it also?

@qoobaa
Owner
qoobaa commented Apr 3, 2013

Tests would be nice.

@brendon
@brendon brendon closed this Jun 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.