Added a check for ensuring the .ssh directory exists. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qoomon
reviewed
Jul 24, 2020
aws-ssm-ec2-proxy-command.sh
Outdated
| --comment "Add an SSH public key to authorized_keys for 60 seconds" \ | ||
| --parameters commands="\" | ||
| cd ~${ssh_user}/.ssh || exit 1 | ||
| [ -f ~/${ssh_user}/.ssh ] || mkdir -p ~/${ssh_user}/.ssh |
Owner
There was a problem hiding this comment.
I think we can omit the test part and only do mkdir -p ~/${ssh_user}/.ssh, cause it checks for existence already.
Owner
|
thank for you PR, looks good to me. |
Author
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to SSM the first time after instance creation, the connections fail because the .ssh directory does not yet exist for the ssm-user.