Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a bug in parsing jsdoc #574

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@johnspackman
Copy link
Member

commented Oct 4, 2019

fixes a bug in parsing jsdoc, where the last compiler hint won't be parsed properly if there is anything on the next line

…arsed properly if there is anything on the next line
@cboulanger

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

Strange build error:

./qx package update
TypeError: qx.tool.cli.ConfigDb is not a constructor
@johnspackman

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

seems unlikely that's down to this PR, given the extent of the change. Here's my output:

Johns-MacBook-Pro:test john$ cd ../../QxCompiler
Johns-MacBook-Pro:QxCompiler john$ ./qx package update
Downloading cache from GitHub ...
Found 287 releases of libraries.
Run 'qx package list' in the root dir of your project to see which versions of these libraries are compatible.
Johns-MacBook-Pro:QxCompiler john$
@johnspackman

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

This was weird - this syntax does not work in native code:

qx.Class.define("blah.Class", {
  construct() {
    this.base(arguments);
  }
});

you get the "is not a constructor" message when trying to new blah.Class(). I've had this before, but do not understand how this slipped through before. This PR is now updated to include fixes for ConfigDb and everywhere else there was the same signature.

The fix BTW is to use construct: function() {} instead of ES6 style construct() {}

@johnspackman

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

PS - for code which is compiled using qx compile the ES6 syntax works just fine...

@hkollmann hkollmann merged commit 7ec077b into qooxdoo:master Oct 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
johnspackman added a commit to johnspackman/qooxdoo-compiler that referenced this pull request Oct 14, 2019
* commit '2b00a827c55bf2d06cc30e0720dbc7dfb50bf23f':
  Update push-to-experimental.yml
  run npm audit fix (qooxdoo#579)
  fix for qooxdoo#570 (qooxdoo#578)
  fixes qooxdoo#575 (qooxdoo#576)
  fixes a bug in parsing jsdoc (qooxdoo#574)
  Fix install of local path (qooxdoo#573)
  Fix for qooxdoo#524 (qooxdoo#571)
  fix for qooxdoo#519
  [ci skip] fix type
  [ci skip] working on actions
  [ci skip] Working on action
  Update push-to-experimental.yml
  Update push-to-experimental.yml
  Update push-to-experimental.yml
  Update push-to-experimental.yml
  Update push-to-experimental.yml
  Update push-to-experimental.yml
  Action for outgoing web hook to qooxdoo/experimental
johnspackman added a commit to johnspackman/qooxdoo-compiler that referenced this pull request Oct 14, 2019
* commit '7ec077b1fc993ce68f399e3907e8334e86618057':
  fixes a bug in parsing jsdoc (qooxdoo#574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.