New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Use of Mutation Events is deprecated. Use MutationObserver instead." warning in Firefox #9300

Open
firewave opened this Issue Mar 17, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@firewave

firewave commented Mar 17, 2017

I am not really sure which widget this actually triggers this, but it somehow originates from inside of the qooxdoo framework and not the application code (possibly qx.ui.embed.Iframe related?).
I see at least two mutation events in the Firefox debugger - one "DOMContentLoaded" and "DOMNodeInserted" (this seems to trigger the warning) both on something in qooxdoo-5.0.2-sdk/framework/source/class/qx/lang/Function.js. I looked a bit on the web and it appears this warnings has been around for several years now and it appears that Chrome also gave this warning at some point. I am not seeing it in Chrome though.

I am using qooxdoo 5.0.2 and Firefox 52 64-bit on Windows 10.

@level420

This comment has been minimized.

Show comment
Hide comment
@level420

level420 Mar 20, 2017

Member

See https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver

It could be that DOM-Events will be deprecated in the future.

Member

level420 commented Mar 20, 2017

See https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver

It could be that DOM-Events will be deprecated in the future.

@schnepe2

This comment has been minimized.

Show comment
Hide comment
@schnepe2

schnepe2 Apr 18, 2017

Contributor

Can someone make a test case for this issue?
It seems that the work-around that has been added (for old Bug 2756 rsp. issue #2887)
should also be applied for current Chrome[1].
At least when the scenario is like the one described in #2887

[1] Version 57.0.2987.133 (64-bit)

Contributor

schnepe2 commented Apr 18, 2017

Can someone make a test case for this issue?
It seems that the work-around that has been added (for old Bug 2756 rsp. issue #2887)
should also be applied for current Chrome[1].
At least when the scenario is like the one described in #2887

[1] Version 57.0.2987.133 (64-bit)

@schnepe2

This comment has been minimized.

Show comment
Hide comment
@schnepe2

schnepe2 Apr 18, 2017

Contributor

By the way: The original issue was, that "relocating" the iframe into another container did not re-render a changed source-URL:

iframe.setSource("http://www.heise.de");
container1.add(iframe, {flex: 1});
window.setTimeout(function() {
  iframe.setSource("http://www.ajaxian.com");
  container2.add(iframe, {flex: 1});                    // <= this one !!
}, 5000);

...but isn't that something that shouldn't be done?

Contributor

schnepe2 commented Apr 18, 2017

By the way: The original issue was, that "relocating" the iframe into another container did not re-render a changed source-URL:

iframe.setSource("http://www.heise.de");
container1.add(iframe, {flex: 1});
window.setTimeout(function() {
  iframe.setSource("http://www.ajaxian.com");
  container2.add(iframe, {flex: 1});                    // <= this one !!
}, 5000);

...but isn't that something that shouldn't be done?

schnepe2 added a commit to schnepe2/qooxdoo that referenced this issue Apr 18, 2017

Added test for issue #9300
Testcase for "SyncSourceAfterDOMMove" added

schnepe2 added a commit to schnepe2/qooxdoo that referenced this issue Apr 18, 2017

Issue 9300 tests (#2)
* Create hello.html

* Added test for issue #9300

Testcase for "SyncSourceAfterDOMMove" added
@schnepe2

This comment has been minimized.

Show comment
Hide comment
@schnepe2

schnepe2 Apr 19, 2017

Contributor

I've integrated tests into the PR ( #9314 ) as @oetiker suggested.

Contributor

schnepe2 commented Apr 19, 2017

I've integrated tests into the PR ( #9314 ) as @oetiker suggested.

level420 added a commit that referenced this issue Apr 27, 2017

Update Iframe.js to use MutationObserver (#9300) (#9314)
* Update Iframe.js

* Update EcmaScript.js

* Added getMutationObserver()

Added getMutationObserver() method
and "ecmascript.mutationobserver" environment variable

* Added "ecmascript.mutationobserver" doc

* Code wrapped in environment check

* ignore(MutationObserver) added

* @ignore(MutationObserver) added

* iframe out-of-sync handler applied for all engines

- iframe-out-of-sync handler applied for all engines
- removed qx.bom.Iframe.getWindow(iframeDomElement).stop() call, cause "edge" and "mshtml" prevent access to it and on all the other engines (I've tested) it seems not to be needed.
(Tested with: Edge, IE 11, FF 52, Chrome 57 & Palemoon 27.2.1)

* (re-)added Window#stop() call

Due to the fact that I don't know under what circumstances the Window.stop() call might be necessary I've re added it again but this time protected by "isIE" checks (...whose Window object do not have a stop() method)

* Issue 9300 tests (#2)

* Create hello.html

* Added test for issue #9300

Testcase for "SyncSourceAfterDOMMove" added

johnspackman added a commit to johnspackman/qooxdoo that referenced this issue May 10, 2017

Merge commit '5754741a2f822e083d02a78e5a4d70a355825b7c'
* commit '5754741a2f822e083d02a78e5a4d70a355825b7c':
  Fix code layout and lint (#9320)
  Fix chrome testrunner on travis
  Update Iframe.js to use MutationObserver (#9300) (#9314)
  removed 'generate test' warnings (#9318)
  Fix edge focus handler (#9315)
  bug fix for complex regex (#9307)
  support css3 transitions in themes (#9312)
  Fix for #9310. (#9311)
  Disable chrome unstable builds
  Issue #9303: Improve mouse wheel normalization code to adjust scrolling sensitivity for touchpads (#9306)
  Issue #9298: removed code for setting a request referer header (#9299)

vvandens added a commit to vvandens/qooxdoo that referenced this issue Jun 6, 2017

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  The flex setting was activated for column 0. Column 0 is the column for the labels. So the labels get stretched and the form fields stay small. (#9341)
  Removes the need for DateFormat instances to be manually disposed, and fixes a bug where locale can change unexpectedly (#9336)
  Fixes a bug where an exception is raised if there is no contentElement, triggered by changing source (#9337)
  take a look underneath the cursor element to fix the dragover event firing (#9332)
  Fix Textarea autosize calculation in special case (#9321)
  workaround for wrong event targets on touch devices (#9327)
  Fix code layout and lint (#9320)
  Fix chrome testrunner on travis
  Update Iframe.js to use MutationObserver (#9300) (#9314)
  removed 'generate test' warnings (#9318)
  Fix edge focus handler (#9315)
  bug fix for complex regex (#9307)
  support css3 transitions in themes (#9312)
  Fix for #9310. (#9311)
  Disable chrome unstable builds
  Issue #9303: Improve mouse wheel normalization code to adjust scrolling sensitivity for touchpads (#9306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment