New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qooxdoo images are not loaded in IE when app is served in https and base URL is set #9353

Open
ronkie opened this Issue Jul 5, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@ronkie
Contributor

ronkie commented Jul 5, 2017

We have a qooxdoo app that is served by Tomcat via https and with base URL set in index.html, so all the resources are served from a different location than index.html location.

There is a Checkbox widget on a page that appears not checked when it actually is. We discovered that it was because chekbox image was not loaded (error 404).
Other images we have in the app are loaded correctly.

There is an issue:
#2564

Code that was added for it adds a prefix for the url to make it absolute, but it does not take into account "base" url, so app tries to load images from the same location as index.html resides.

@ronkie

This comment has been minimized.

Show comment
Hide comment
@ronkie

ronkie Jul 5, 2017

Contributor

image not found ie

Contributor

ronkie commented Jul 5, 2017

image not found ie

ronkie added a commit to ronkie/qooxdoo that referenced this issue Jul 5, 2017

#9353 Qooxdoo images are not loaded in IE when app is served in https…
… and base URL is set

Use base url if it is present

ronkie added a commit to ronkie/qooxdoo that referenced this issue Jul 10, 2017

#9353 Qooxdoo images are not loaded in IE when app is served in https…
… and base URL is set

Use qx.bom.Selector.query("base", document) instead of qxWeb

ronkie added a commit to ronkie/qooxdoo that referenced this issue Jul 11, 2017

cajus added a commit that referenced this issue Jul 26, 2017

Merge pull request #9354 from ronkie/ie_images_problem
#9353 Qooxdoo images are not loaded in IE when app is served in https…
@level420

This comment has been minimized.

Show comment
Hide comment
@level420

level420 Jul 26, 2017

Member

Fixed via #9354

Member

level420 commented Jul 26, 2017

Fixed via #9354

@level420 level420 closed this Jul 26, 2017

johnspackman added a commit to johnspackman/qooxdoo that referenced this issue Jul 29, 2017

Merge commit 'cf2960ec22d9a257fce3e33e53c316fdffa5adca'
* commit 'cf2960ec22d9a257fce3e33e53c316fdffa5adca':
  Revert formatting
  #9353 Qooxdoo images are not loaded in IE when app is served in https and base URL is set Code style issues
  #9353 Qooxdoo images are not loaded in IE when app is served in https and base URL is set Use qx.bom.Selector.query("base", document) instead of qxWeb
  #9353 Qooxdoo images are not loaded in IE when app is served in https and base URL is set Use base url if it is present

johnspackman added a commit to johnspackman/qooxdoo that referenced this issue Aug 24, 2017

Merge commit 'a6e01cab1f28530b848d7ea88dbb4836db554f3e'
* commit 'a6e01cab1f28530b848d7ea88dbb4836db554f3e':
  Fixes JSDoc comments, plus a couple of very minor bugs detected by the TypeScript generator
  Fixed dimensions (width and height) of AbstractScrollArea (issue 9351) (#9355)
  Fix for #9362 (#9370)
  raise timeout for test qx.test.ui.embed Iframe:testSyncSourceAfterDOMMove to make travis happy (#9368)
  Wait for drop down list to be rendered before accessing bounds (#9371)
  remove all grunt stuff (#9364)
  removed trailing ?>
  allow qx.test.io.remote.transport.XmlHttp:testSetHeader to be run under php-fpm
  Small correction to the help text. (#9363)
  Added AutoHide Functionality to ToolTip Manager (#9359)
  qx.ui.core.scroll.MRoll: change member cancelRoll from private to protected
  Fix for issue #9334 (#9357)
  Revert formatting
  #9353 Qooxdoo images are not loaded in IE when app is served in https and base URL is set Code style issues
  #9353 Qooxdoo images are not loaded in IE when app is served in https and base URL is set Use qx.bom.Selector.query("base", document) instead of qxWeb
  #9353 Qooxdoo images are not loaded in IE when app is served in https and base URL is set Use base url if it is present
@derrell

This comment has been minimized.

Show comment
Hide comment
@derrell

derrell Oct 24, 2017

Member

Unfortunately, this change breaks existing code. The class qx.util.ResourceManager is used in non-GUI code, where document does not exist. We need to find a different way of solving the original problem, or ensure that this code still works in non-GUI environments.

Member

derrell commented Oct 24, 2017

Unfortunately, this change breaks existing code. The class qx.util.ResourceManager is used in non-GUI code, where document does not exist. We need to find a different way of solving the original problem, or ensure that this code still works in non-GUI environments.

@derrell derrell reopened this Oct 24, 2017

@derrell

This comment has been minimized.

Show comment
Hide comment
@derrell

derrell Oct 24, 2017

Member

I've tracked this down further. The problem is that the patch puts a dependency in qx.util.ResourceManager on qx.bom.Selector which brings in the Sizzle library that tries to do a bunch of stuff at initialization time that assumes a GUI environment. There can not be a dependency on qx.bom.Selector in qx.util.ResourceManager.

Member

derrell commented Oct 24, 2017

I've tracked this down further. The problem is that the patch puts a dependency in qx.util.ResourceManager on qx.bom.Selector which brings in the Sizzle library that tries to do a bunch of stuff at initialization time that assumes a GUI environment. There can not be a dependency on qx.bom.Selector in qx.util.ResourceManager.

@level420

This comment has been minimized.

Show comment
Hide comment
@derrell

This comment has been minimized.

Show comment
Hide comment
@derrell

derrell Oct 24, 2017

Member

Correct, but the whole patch appears to depend on that...

Member

derrell commented Oct 24, 2017

Correct, but the whole patch appears to depend on that...

@ronkie

This comment has been minimized.

Show comment
Hide comment
@ronkie

ronkie Oct 24, 2017

Contributor

Hi guys,

I've used qxWeb at first, but that was also not good?

ronkie@167eb14

Maybe we could simply use

document.querySelectorAll("base")

But before checking for the document, if it is there....

Contributor

ronkie commented Oct 24, 2017

Hi guys,

I've used qxWeb at first, but that was also not good?

ronkie@167eb14

Maybe we could simply use

document.querySelectorAll("base")

But before checking for the document, if it is there....

@level420

This comment has been minimized.

Show comment
Hide comment
@level420

level420 Oct 25, 2017

Member

@ronkie could you please verify if the solution in PR #9415 works for you? Thank you!

Member

level420 commented Oct 25, 2017

@ronkie could you please verify if the solution in PR #9415 works for you? Thank you!

level420 added a commit to level420/qooxdoo that referenced this issue Mar 23, 2018

Merge pull request #9354 from ronkie/ie_images_problem
#9353 Qooxdoo images are not loaded in IE when app is served in https…
Conflicts:
	framework/source/class/qx/util/ResourceManager.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment