Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'click' event not being fired for menu button in Firefox 66 #9645

Open
milandamen opened this issue Mar 22, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@milandamen
Copy link
Contributor

commented Mar 22, 2019

Description
Since Firefox 66, the 'click' event is no longer being fired for qx.ui.menu.Button widgets. It still works in older versions of Firefox and newest Chrome.

Reproduction

var menuBar = new qx.ui.menubar.MenuBar();

var menuItem = new qx.ui.menubar.Button('Menu item');
var submenu = new qx.ui.menu.Menu();
var submenuItem = new qx.ui.menu.Button('Submenu item 1');

submenu.add(submenuItem);
menuItem.setMenu(submenu);
menuBar.add(menuItem);

this.getRoot().add(menuBar);

submenuItem.addListener('click', function (event) {
  alert('submenu item 1 clicked');
});




var label = new qx.ui.basic.Label('Some label');
this.getRoot().add(label, {top: 100});

var menu2 = new qx.ui.menu.Menu();
var item2 = new qx.ui.menu.Button('Submenu item 2');

menu2.add(item2);
label.setContextMenu(menu2);

item2.addListener('click', function (event) {
  alert('submenu item 2 clicked');
});
  1. Open a menu. It does not matter if the menu was opened using a widget contextmenu (rightclick) or using a MenuBar Button.
  2. Click on a menu item in the menu.

Actual result
No 'click' event gets fired by the browser, so Qooxdoo does not dispatch it to the rest of the application.

Expected result
The 'click' event gets fired by the browser and Qooxdoo will dispatch it.

Possible cause
This is speculation, but I think Qooxdoo might be stopping the browser from firing the 'click' event, because the browser fires 'pointerdown' and 'pointerup' correctly.
I have tried reproducing this with pure HTML without Qooxdoo and it fired the 'click' event correctly.

Workaround
Listen to 'execute' or 'tap' instead of 'click' on the menu button.

@cboulanger

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Which version of qooxdoo are you using? We are just in the process of backporting fixes from v6 to v5 and this might already be fixed in version 6. @level420, can you comment?

@milandamen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

I am using the tip of master at the moment (7ce1e45). It's still broken on Firefox 66.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.