Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Debug console shown unexpectedly #9655

Open
benzen opened this issue Mar 28, 2019 · 18 comments

Comments

Projects
None yet
5 participants
@benzen
Copy link
Contributor

commented Mar 28, 2019

Describe the bug
A debug console is shown unexpectedly.

To Reproduce
Use my app
1-either focused in a field, or not
2-press the lower case v

Expected behavior
If focused on a field write the letter v, otherwhise nothing.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: macos and windows
  • Browser firefox
  • Version 66.

Additional context
Firefox 65 didn't raise this issue

@benzen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

Capture d’écran, le 2019-03-28 à 15 58 51
Here is a print screen of this.

Of course i never intended to show this console.
And in chrome i don't have this problem

@cboulanger

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Can you please try this:
https://github.com/qooxdoo/qooxdoo/releases/tag/v5.0.3-beta
and see if it fixes your problems? Thank you.

@benzen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

Is it possible to make a release into maven central for this ?

@cboulanger

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

I am afraid you'll have to manually download the ZIP from the tag and replace your qooxdoo installation with it. We do not have maven integration at this point.

@benzen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

I confirm this fix my issue.

When is planned the official release ?

@cboulanger

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

If no issues are reported with the beta, we can release it soon. Unfortunately, the extensive qooxdoo test suite is no longer compatible with v5 so we cannot test these releases ourselves.

BTW if Maven is important to you, we have a very old repository which is about Maven integration: https://github.com/qooxdoo/maven-central-integration but I know nothing about it or about how much effort it would be to resuscitate it. Maybe you want to have a look?

@Holdwyn

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Seems that the keypress event is not fired anymore for non printable keys.

@cboulanger

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

@Holdwyn

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Yes, sorry forgot to mentioned that I alredy tried 5.0.3-beta. We prevent the browser reload by "F5" keypress event. This isn't working anymore with the hotfix version and FF 66. Navigating in tables by arrow keys is also broken.

@benzen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Since there is no that much activity arround qooxdoo.
I suppose il will be pretty hard to have report of issues on this new release.

Is the effort to update the extensive test suite that much of a problem ?

@cboulanger

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

@benzen The activity is in the v6 branch, which is almost 100% backwards-compatible with v5 and in use in several production systems. Do not fear the "-alpha.*" version, it just indicates that it is still changing - but only concerning new features. You likely will run into a few small issues during migration but overall the upgrade will be worth it since you'll get all bugfixes and full browser compatibility.

@Holdwyn

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Could you point me to the v6 branch? I'm unable to find it in the branches list...

@derrell

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@Holdwyn It's the master branch.

@cboulanger

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Yes sorry if I was unclear. All development is in the master branch, which is considered safe for general consumption. It is advisable not to update each time a new commit lands since there might be regressions (that's why it is "alpha"). But as I said, the master branch is used in real projects and it is thoroughly tested in a really extensive test suite that runs for more than 2 hours: https://travis-ci.org/qooxdoo/qooxdoo/builds/511008181. We still don't have a release schedule for v6 because it involves much more than just the code (documentation, website, etc.), but it is on the horizon.

@level420

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Yes, sorry forgot to mentioned that I alredy tried 5.0.3-beta. We prevent the browser reload by "F5" keypress event. This isn't working anymore with the hotfix version and FF 66. Navigating in tables by arrow keys is also broken.

@Holdwyn just tested the tables navigation with 5.0.3-beta and firefox 66.0.2 (64-Bit) on windows 7 and windows 10 and it works as expected. Could you please share your browser version and os and how you tested? Thank you.

@Holdwyn

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Yes, sorry forgot to mentioned that I alredy tried 5.0.3-beta. We prevent the browser reload by "F5" keypress event. This isn't working anymore with the hotfix version and FF 66. Navigating in tables by arrow keys is also broken.

@Holdwyn just tested the tables navigation with 5.0.3-beta and firefox 66.0.2 (64-Bit) on windows 7 and windows 10 and it works as expected. Could you please share your browser version and os and how you tested? Thank you.

I downloaded the sources zip file (https://github.com/qooxdoo/qooxdoo/releases) and replaced the qooxdoo 5.0.2 checkout from git with it. Then I called generate clean and generate source. If I focus a table cell and try to use the arrow keys to move the focus it didn't work with FF 66.0.2 (64-Bit) on Windows 10 Version 1809.

@benzen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

So my initial problem seems to be solved, but @Holdwyn seems to still see an issue with 5.0.3.

Can we have a feedback on this ?

@level420

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@benzen could you please check if table cell navigation with arrow keys works for you? thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.