Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming doesn't support background images with spaces in their names #9674

Open
mrfeet opened this issue May 15, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@mrfeet
Copy link
Contributor

commented May 15, 2019

*When creating a custom theme and referencing background images with a space in their name, these images are not shown.

The problem is in qx.bom.element.Background.js, that doesn't take spaces in image urls into account:

var backgroundImageCssString;
if (this.__isBase64EncodedImage(backgroundImageUrl)) {
backgroundImageCssString = "url('" + backgroundImageUrl + "')";
} else {
backgroundImageCssString = "url(" + backgroundImageUrl + ")";
}

So only for base64 urls the url is quoted. But this quoting also needs to be done when the url contains a space.

So my suggestion is to remove the check for base64encoding and always include the quotes.

I will supply a pull request for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.