Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting property method qx.ui.splitpane.Splitter.isVisible with qx.ui.core.Widget #9719

Open
schnepe2 opened this issue Jun 27, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@schnepe2
Copy link
Contributor

commented Jun 27, 2019

The "fix" for #9649 introduced a (runtime-)warning, as it is "overriding" a generated property metghod:
008327 Conflicting property method qx.ui.splitpane.Splitter.isVisible with qx.ui.core.Widget

To Reproduce
Just run an app (source build) which has a Splitter.

Expected behavior
No warnings / errors whatsoever.

@hkollmann

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

@johnspackman : Why do you closed this?

@johnspackman

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Because it was solved by the PR #9649 which was just merged

@johnspackman

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

oh hang on, no it's not!!

@johnspackman johnspackman reopened this Jun 27, 2019

@hkollmann

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

It's another issue...

@schnepe2

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Should I change the title so it doesn't contain the responsible PR?
(this is what triggered @johnspackman, right?)

@schnepe2

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

BTW: Last time such an issue came up (#9313), renaming of the method was proposed!
showKnob might be an alternative name for it.

@schnepe2 schnepe2 changed the title (Runtime-)warning after (#9649) Conflicting property method qx.ui.splitpane.Splitter.isVisible with qx.ui.core.Widget Jun 28, 2019

@schnepe2

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

Took a look at the things PR #9649 introduced and I am not sure what to think of it.

  1. The documentation of qx.ui.splitpane.Splitter#visible property is plain wrong, as it only applies the visibility of the Splitters knob!
  2. The changes in qx.ui.splitpane.Pane seem also to just work with one special case
    (Try a theme with a different sized knob and you'll probably see things go crazy).
  3. Shouldn't all the public properties, members and methods of Splitter (getChildControl("knob"), setVisibility("visible"), setVisibility("excluded"), getVisibility(), etc. pp.) be enough for any application programmer to derive a class from it? This request looks like a very special use-case to me.

For the "quick fix" a rename of property qx.ui.splitpane.Splitter#visible into qx.ui.splitpane.Splitter#knobVisible might be enough, but still I feel like the whole idea has to be tested a lot more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.