Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong computation of embedded widget's width. #9858

Open
ertmnv opened this issue Jan 28, 2020 · 0 comments
Open

Wrong computation of embedded widget's width. #9858

ertmnv opened this issue Jan 28, 2020 · 0 comments

Comments

@ertmnv
Copy link

@ertmnv ertmnv commented Jan 28, 2020

When we try to embed widget on site which contains something like this:

body * {
font-family: "SomeFont" !important;
}
we get incorrect width for qx.ui.basic.Label.

it is caused by following snippet from qooxdoo/framework/source/class/qx/bom/Label.js:

__measureSize : function(element, styles)
{
  // sync styles
  var keys = this.__styles;

  if (!styles) {
    styles = {};
  }

  for (var key in keys) {
    element.style[key] = styles[key] || "";
  }

  // detect size
  var size = qx.bom.element.Dimension.getSize(element);

  // all modern browser are needing one more pixel for width
  size.width++;

  return size;
}

when we set style for element in snippet specified above, we don't specify value which is being set as important. So specified properties can be override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.