Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sinon #9897

Open
cboulanger opened this issue Mar 16, 2020 · 3 comments
Open

Update sinon #9897

cboulanger opened this issue Mar 16, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@cboulanger
Copy link
Contributor

@cboulanger cboulanger commented Mar 16, 2020

The sinon library included in qx.dev.unit.* is very old and needs to be updated. For example, it suffers from sinonjs/sinon#1709 . See also #9277

@cboulanger cboulanger added this to the release_6_0_0 milestone Mar 16, 2020
@cboulanger cboulanger self-assigned this Mar 16, 2020
@hkollmann

This comment has been minimized.

Copy link
Member

@hkollmann hkollmann commented Mar 16, 2020

Be careful - i patched the sinon part recently so that it cam work with qooxdoo and node...

@cboulanger

This comment has been minimized.

Copy link
Contributor Author

@cboulanger cboulanger commented Mar 16, 2020

Thanks for letting me know. Can you link to the diff here, so that I don't forget? I don't know when I will have time to revisit the issue. I'll have to upgrade carefully anyways since any incompatibility will break the framework tests.

@hkollmann

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.