Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cherry picked PRs from master to branch_5_0_x #9624
Pushed some more cherry-picked PRs with the intention to fix the tests. Here locally down from about 100 failing tests to 36. It's a hard job to identify all the those PRs which fixed the tests.
BTW: @oetiker ported the travis tests back on 12. Aug 2018: #9125 to branch_5_0_x where the travis job promptly failed: https://travis-ci.org/qooxdoo/qooxdoo/builds/151754600 for firefox with 86 failed tests and chrome with 95 failed tests.
At some point merging was blocked per rule when the travis check failed, thus not allowing us to merge anymore in branch_5_0_x
Closing this PR as I think that by trying to fix the testrunner to succeed, I've cherry picked more PRs than needed to only backport some fixes into the 5_0_x branch.
My strong opinion is that we don't have a chance to fix the tests in the 5_0_x branch without fixing the framework, which means that we will end having everything in 5_0_x what we also have in 6_0_x.
One main big obstacle was, that fixes were committed along with changes for the testing framework which lead to the cherry picks not being applicable as a is, but had to be manually unthreaded into the bug fix and the test framework enhancements.
I've learned a lot about git, cherry picking, github commit hashes and so forth, but I fear my efforts were waste of time in relation to backporting bug fixes to branch_5_0_x.