Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression causing circular load time dependency #9797

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@johnspackman
Copy link
Member

commented Oct 2, 2019

fixes a bug in the last commit where the generator will complain about circular dependencies:

>>> Collecting classes  /
  - Warning: Detected circular dependency between: qx.event.Manager and qx.core.Object
<type 'exceptions.RuntimeError'> :
Circular class dependencies
@pullapprove pullapprove bot requested a review from zaucker Oct 2, 2019
@hkollmann hkollmann merged commit ff7f689 into qooxdoo:master Oct 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pullapprove 1 group approved
Details
johnspackman added a commit to johnspackman/qooxdoo that referenced this pull request Oct 9, 2019
* fix-uuid-for-node:
  fixes a bug where uuid is not available for node apps
  add support for breaking within words in labels (qooxdoo#9796)
  fix regression causing circular load time dependency (qooxdoo#9797)
johnspackman added a commit to johnspackman/qooxdoo that referenced this pull request Oct 15, 2019
* commit 'd4f92e12d4826d14c90a80da0a75fe95fdeb23cf':
  add support for breaking within words in labels (qooxdoo#9796)
  fix regression causing circular load time dependency (qooxdoo#9797)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.