Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test on Number related locale #9807

Open
wants to merge 2 commits into
base: master
from

Conversation

@rommni
Copy link

rommni commented Nov 5, 2019

Like discussed on qooxdoo/qooxdoo-compiler#587 add test to number related locale value.

Testing fr locale allow to test that the locale linked to defaultNumberingSystem are loaded and not just the first one declared in cldr files

return;
}

var Number = qx.locale.Number;

This comment has been minimized.

Copy link
@cboulanger

cboulanger Nov 5, 2019

Contributor

Overwriting the native Number object is certainly legal, but is it a good idea? Maybe use a different symbol?

This comment has been minimized.

Copy link
@level420

level420 Nov 5, 2019

Member

@cboulanger: do you mean the name of the test class? It’s not qx.locale.Number, it’s qx.test.locale.Number!

This comment has been minimized.

Copy link
@level420

level420 Nov 5, 2019

Member

Ah! Sorry you mean Number! Yes. this should be avoided.

This comment has been minimized.

Copy link
@rommni

rommni Nov 6, 2019

Author

Hum effectively i took the code from the qx.test.locale.Date, i will change that.

@hkollmann

This comment has been minimized.

Copy link
Member

hkollmann commented Nov 5, 2019

I am missing the change of compile.json for the french locale?

@rommni

This comment has been minimized.

Copy link
Author

rommni commented Nov 6, 2019

@hkollmann after more investigating the change wasn't needed, the fact is that for testing i added the qxl.testtapper package and was running the test with it and this one was compiled using compile.json settings and so was lacking the fr locale, however the framework config settings contains the french locale.

@hkollmann

This comment has been minimized.

Copy link
Member

hkollmann commented Nov 6, 2019

Can you add your testtapper compile.json as compileTest.json?

@rommni

This comment has been minimized.

Copy link
Author

rommni commented Nov 6, 2019

@hkollmann of course i can, do you want me to push my Manifest.json and qx-lock.json with testtapper add too? Maybe only the qx-lock? Currently i include in compile.json testtapper app only my qx.test.locale.Number class, should i let this or change it?

@oetiker
oetiker approved these changes Nov 7, 2019
@hkollmann

This comment has been minimized.

Copy link
Member

hkollmann commented Nov 7, 2019

I suggest a project in testgui from where the testrunner can run. Your test is not working in the python toolchain. With this test project we are able to run the tests with the compiler tool chain.

@cboulanger

This comment has been minimized.

Copy link
Contributor

cboulanger commented Nov 7, 2019

@hkollmann Do you mean the test breaks the python toolchain (because the tests seem to pass), or it simply doesn't run in the generator-based toolchain. Because if the latter is the case, it doesn't really matter, does it?

@hkollmann

This comment has been minimized.

Copy link
Member

hkollmann commented Nov 7, 2019

It's not running. But i would like to archive the test project as a base for changing the test procedure

Copy link
Member

hkollmann left a comment

Please add the test project

@rommni

This comment has been minimized.

Copy link
Author

rommni commented Nov 8, 2019

sorry a little busy currently, i'll looking that as soon as i have the time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.