Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is no timeout in websocket socket operations in the WebSocketHandler module #1725

Closed
davidnich opened this issue Mar 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@davidnich
Copy link
Contributor

commented Mar 2, 2017

this can leave threads blocked indefinitely under the right (or "wrong") conditions - ex:

TID 383
 1: Socket::send() called at /appl/isepl/it-sit5/qlib/WebSocketHandler.qm:282 (builtin function)
 2: WebAppSocketHandler::startImpl() called at /appl/isepl/it-sit5/qlib/HttpServerUtil.qm:1068 (user function)
 3: WebAppSocketHandler::start() called at /appl/isepl/it-sit5/qlib/HttpServer.qm:1639 (user function)
 4: QorusHttpServer::sendReply() called at /appl/isepl/it-sit5/qlib/HttpServer.qm:1523 (user function)
 5: QorusHttpServer::handleRequest() called at /appl/isepl/it-sit5/qlib/HttpServer.qm:2212 (user function)
 6: HttpListener::connectionThread() called at /appl/isepl/it-sit5/qlib/HttpServer.qm:2034 (user function)
 7: HttpListener::<anonymous closure>() called at :-1 (user function)

@davidnich davidnich added this to the 0.8.12.8 milestone Mar 2, 2017

@davidnich davidnich self-assigned this Mar 2, 2017

@davidnich davidnich changed the title there is no timeout in websocket send operations in the WebSocketHandler module there is no timeout in websocket socket operations in the WebSocketHandler module Mar 2, 2017

davidnich added a commit that referenced this issue Mar 2, 2017

refs #1725 implemented timeout handling for websocket messaging (clie…
…nt & server), added a test + relnotes
@pavelkveton

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

@davidnich could you give me an insight on the impact of the missing timeout?

AFAIK we use websockets only to communicate to the web UI (right?), so the handler can wait forever only in case the webUI (browser) terminates unexpectedly (right?).

which is probably always, i.e. the issue IS important.

or am I missing something, pls?

pavelkveton added a commit that referenced this issue Mar 2, 2017

Merge pull request #1726 from qorelanguage/bugfix/1725_websocket_time…
…outs

refs #1725 implemented timeout handling for websocket messaging (clie…

@davidnich davidnich added the fixed label Mar 2, 2017

@davidnich davidnich closed this Mar 2, 2017

@davidnich

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2017

issue discussed out of line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.