New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger module does not correctly handle string type with date or date-type format #2341

Closed
omusil24 opened this Issue Oct 26, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@omusil24
Contributor

omusil24 commented Oct 26, 2017

example:

definitions:
  Person:
    type: object
    properties:
      birthdate:
        type: string
        format: date
        example: "1987-05-23"

@omusil24 omusil24 added this to the 0.8.13.1 milestone Oct 26, 2017

@omusil24 omusil24 added the notabug label Oct 26, 2017

@omusil24

This comment has been minimized.

Show comment
Hide comment
@omusil24

omusil24 Oct 26, 2017

Contributor

Actually a problem of swagger2service, not Swagger module.

Contributor

omusil24 commented Oct 26, 2017

Actually a problem of swagger2service, not Swagger module.

@omusil24 omusil24 closed this Oct 26, 2017

@omusil24 omusil24 changed the title from swagger module does not correctly handle string type with date or date-type format to Swagger module does not correctly handle string type with date or date-type format Oct 26, 2017

@omusil24 omusil24 removed the notabug label Oct 26, 2017

@omusil24 omusil24 reopened this Oct 26, 2017

@omusil24

This comment has been minimized.

Show comment
Hide comment
@omusil24

omusil24 Oct 26, 2017

Contributor

Actually it is a problem of Swagger module since swagger2service only calls getQoreExample functions from the Swagger module and prints their output.

Contributor

omusil24 commented Oct 26, 2017

Actually it is a problem of Swagger module since swagger2service only calls getQoreExample functions from the Swagger module and prints their output.

@omusil24 omusil24 self-assigned this Oct 26, 2017

omusil24 added a commit that referenced this issue Oct 26, 2017

Fixed #2342 wrong example value for binary type in Swagger module and #…
…2341 handling of the string type date and date-time formats in the Swagger module

omusil24 added a commit that referenced this issue Oct 26, 2017

@omusil24 omusil24 added the module label Oct 26, 2017

omusil24 added a commit that referenced this issue Oct 26, 2017

Reverted original string/date Swagger module fix for #2341 and added …
…auto-conversion to date values for date example values

davidnich added a commit that referenced this issue Oct 26, 2017

davidnich added a commit that referenced this issue Oct 26, 2017

refs #2341 fixed handling of string type date and date-time formats
refs #2349 fixed serialization of date/time values

@omusil24 omusil24 added the fixed label Oct 27, 2017

@omusil24 omusil24 closed this Oct 27, 2017

omusil24 added a commit that referenced this issue Oct 27, 2017

Merge pull request #2350 from qorelanguage/bugfix/2341_2349_Swagger_f…
…ixes

refs #2341 fixed handling of string type date and date-time formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment