/qore

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test::testSkip() should take varargs to format the msg #3172

Closed
davidnich opened this Issue Dec 8, 2018 · 0 comments

Comments

Assignees

@davidnich davidnich

Labels
feature fixed not-c++
Projects
None yet
Milestone
  0.9
1 participant
@davidnich
@davidnich
Copy link
Contributor

davidnich commented Dec 8, 2018

ex:

unhandled QORE System exception thrown in TID 1 at 2018-12-08 11:46:33.416985 Sat +01:00 (CET) at ../test/jni.qtest:134
CALL-WITH-TYPE-ERRORS: call to method Test::testSkip(string reason) made as Test::testSkip(string, *string, auto, auto) (with 3 excess arguments); this is an error when PO_REQUIRE_TYPES or PO_STRICT_ARGS is set

@davidnich davidnich added feature not-c++ labels Dec 8, 2018

@davidnich davidnich added this to the 0.9 milestone Dec 8, 2018

@davidnich davidnich self-assigned this Dec 8, 2018

davidnich added a commit that referenced this issue Dec 8, 2018

@davidnich
refs #3172 updated QUnit::Test::testSkip() to format the reason string
Loading status checks…
da7d53a

sejvlond added a commit that referenced this issue Dec 10, 2018

@davidnich @sejvlond
refs #3172 updated QUnit::Test::testSkip() to format the reason string ( 
#3173)
8d878fa

@davidnich davidnich added the fixed label Dec 11, 2018

@davidnich davidnich closed this Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment