New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LOGBACK-540] Filtering out selected stack trace frames #244
Conversation
Thanks for the contribution, @nurkiewicz. Please add a comment here with release notes (see rule P7 of CONTRIBUTING.md). |
Thanks @tony19 for review, fixed. Release notes comment: <p>Irrelevant or internal stack trace lines can now be omitted. Pull request provided by
Tomasz Nurkiewicz (<a href="http://jira.qos.ch/browse/LOGBACK-540">LOGBACK-540</a>).
</p> |
[LOGBACK-540] Filtering out selected stack trace frames
@nurkiewicz, please also update the docs to indicate this new feature. Thanks |
Thanks, I'm about to leave for vacation for two weeks, will do a separate PR with documentation changes after that. |
@nurkiewicz Did you get a chance to raise the documentation PR? I had a quick look for it, but couldn't find it. I'm having difficulty getting the cool new functionality to work. |
No, sorry. I will document this feature within next few days. In the meantime feel free to reach me directly, I'll try to help. |
@nurkiewicz Ah, turns out it was a PEBKAC issue! All working splendidly now. Thanks very much, this feature is helping me mitigate a production log velocity issue. |
Hi, |
Is this going to be documented in the layouts page of the guide? Also it doesn't seem to work well when using logback's colors for patterns. |
This PR adds capability of filtering selected stack frames if it's decided that they are irrelevant. You can use it by defining patterns that, if are contained within stack line, suppress displaying it:
If some stack lines were ignored while showing stack trace, small indicator tells how many lines were skipped:
Issues is discussed in
[LOGBACK-540]
and further discussed here: Filtering irrelevant stack trace lines in logs