Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BasicMarkerFactory by using ConcurrentMap #40

Merged
merged 1 commit into from Jul 3, 2013

Conversation

@ash2k
Copy link
Contributor

ash2k commented Jun 6, 2013

Problems fixed:

  1. unsafe publication because of constructor lacks synchronized(this)
    when assigning markerMap
  2. detachMarker() lacks synchronization
Problems fixed:
1. unsafe publication because of constructor lacks synchronized(this)
when assigning markerMap
2. detachMarker() lacks synchronization
@ash2k

This comment has been minimized.

Copy link
Contributor Author

ash2k commented Jun 7, 2013

Also this improves concurrency of operations in this factory.

@ash2k

This comment has been minimized.

Copy link
Contributor Author

ash2k commented Jun 10, 2013

@ceki, will you merge that? This is a bugfix :)

@ash2k

This comment has been minimized.

Copy link
Contributor Author

ash2k commented Jul 3, 2013

Can someone merge this please?

@mattbishop

This comment has been minimized.

Copy link
Contributor

mattbishop commented Jul 3, 2013

I reviewed this change and it looks good to me. He checks to make sure that he is not overwriting another marker write during the time he is making a new one.

mattbishop added a commit that referenced this pull request Jul 3, 2013
Fix BasicMarkerFactory by using ConcurrentMap
@mattbishop mattbishop merged commit 2db60ef into qos-ch:master Jul 3, 2013
@ash2k ash2k deleted the ash2k:marker-synchronization branch Jul 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.