POC: use roave/better-reflection #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoench
force-pushed
the
better-reflection
branch
2 times, most recently
from
78c9102
to
7c20e3f
Compare
smoench
force-pushed
the
better-reflection
branch
from
7c20e3f
to
e649104
Compare
smoench
force-pushed
the
master
branch
2 times, most recently
from
65a288b
to
d847884
Compare
added 4 commits
June 24, 2020 13:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With better-reflection we would have a better solution not to blame violations with internal classes.
Currently does not work as of Roave/BetterReflection#643