Move getDefaultFile to trait #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use it for DebugCommands. - DebugLayer layer is now optional, if no layer is provided all layers will be printed
gennadigennadigennadi
force-pushed
the
main
branch
from
54bf2ac
to
cee8d3e
Compare
|
This is just me, but I am not a fan of traits and rather saw a common parent class. Otherwise, I like it. :) |
|
This is only temporary anyway, as we will remove support for the old filename at some point anyway. So, I see no reason to split hairs over trait vs. abstract class just for this. Thanks @gennadigennadigennadi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #689