Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dataset): remove NumVersions #267

Open
ramfox opened this issue Sep 3, 2021 · 0 comments
Open

refactor(dataset): remove NumVersions #267

ramfox opened this issue Sep 3, 2021 · 0 comments
Labels
refactor A code change that neither fixes a bug nor adds a feature

Comments

@ramfox
Copy link
Member

ramfox commented Sep 3, 2021

The NumVersions field was added in #177 to compensate for the fact that we, at that point, had no other reliable way to cache the number of versions a dataset has.

Now, with the advent of collection, we do! There is no reason to keep NumVersions on the dataset model any longer.
@ramfox ramfox added the refactor A code change that neither fixes a bug nor adds a feature label Sep 3, 2021
@ramfox ramfox mentioned this issue Sep 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramfox