Added support for Minitest 5 #41

Merged
merged 6 commits into from Apr 23, 2015

Projects

None yet

5 participants

@unmanbearpig
Contributor

No description provided.

@markbates
Contributor

@qrush m is broken for Minitest 5, any chance you can merge this PR in so it can work again? Thanks.

@qrush
Owner
qrush commented Mar 19, 2014

If we can get this tested, I'll happily merge it.

@markbates
Contributor

@unmanbearpig can you get some tests in there so @qrush can merge it?

@unmanbearpig
Contributor

I can't figure out how to test this, can someone help me out a bit?
There is a dependency on minitest 2.11.4 in Gemfile.lock and if I update it a bunch of tests break.
Is there a way to load minitest 5 just for one test example?

zamith added some commits Mar 21, 2014
@zamith zamith Support for Minitest 5
Uses Appraisal in order to test the different versions of minitest. The
entire test suite will not run with minitest 5, since ruby relies on
`Minitest::Unit::TestCase`, which was deprecated.

Also, the previous solution was flawed since the `Minitest` constant was
defined in minitest 4 as an alias to `MiniTest`, therefore I also check
for the version number (`Minitest::Unit::VERSION`).

I extracted the logic of checking which framework is loaded to a
separate class, `M::Frameworks`, so it can be checked them on both the
tests and the library code.
4df56ee
@zamith zamith Adds minispec back to the gemspec as a dependency 4f60c61
@zamith zamith Reverts indentation changes 76ebfb8
@zamith zamith Corrects indentation b588c25
@zamith zamith Be more consistent with the requires 07ff360
@zamith zamith referenced this pull request in unmanbearpig/m Mar 21, 2014
Merged

Support for Minitest 5 #1

@zamith
Collaborator
zamith commented Mar 21, 2014

@qrush @markbates I've added some tests and corrected a few problems. As I refer in the pull request, there is a problem with using minitest 5 and ruby's test/unit, but the integration is a bit hacky.

@trptcolin

👍 This would be great to have! What can I do to help? @zamith I think maybe your PR should be to qrush/m instead of unmanbearbig/m?

@zamith
Collaborator
zamith commented Jun 24, 2014

@trptcolin I did the pr to unmanbearpig/m, because I built on top of that. But I can open a separate pr for this repo.

@zamith zamith referenced this pull request Jun 24, 2014
Merged

Support for Minitest 5 #43

@zamith zamith merged commit 07ff360 into qrush:master Apr 23, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment