New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features #11
New features #11
Conversation
chrivers
commented
Mar 6, 2011
- Fixed the demos (use setattr(x, "y", z) instead of x.y = z on javascript types
- Created a makefile to generate the examples
- Set up all the py2js code in a py2js module (executable is now called pyjs.py)
- Code cleanups
Sorted everybody alphabetically.
+ Added --output=OUTPUT option to redirect output to a file
…mpiler is implemented
…nd spelling fix)
… not work fully before we have a dual-mode compiler.
Hi, I run examples and they work. However, the tests fail for me: $ ./run_tests.py Testing the file: tests/test_builtins.js [OK] Testing the file: tests/test_compile_js.py [OK] tests/algorithms/sqrt.py [4]: .. [FAIL] so -1 to this pull request until it is fixed. |
But otherwise I agree with the changes and thanks for the patch! Let's get the tests fixed and push this in. |
think the run_tests script is not updated with the new compile script name |
You're right, run_tests was missing an update. Everything is working again now, but I'm not sure how to merge the newest commits? |
merge? |
…ications and libraries that might use run_tests.py
Well Ondrej said we both have push access to qsnake/py2js now, but that non-trivial merges should go through a pull request. I assume there is some way in github to approve the pull request, so the changes will be merged? Or is this done through git? |
i think its thrugh git.. |
When you push it in, the pull request closes automatically. The reason to send things through pull requests (even though you have rights to push it in directly) is so that we can review it publicly before it goes in. |