Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features #11

Merged
18 commits merged into from Mar 7, 2011
Merged

New features #11

18 commits merged into from Mar 7, 2011

Conversation

chrivers
Copy link

@chrivers chrivers commented Mar 6, 2011

  • Fixed the demos (use setattr(x, "y", z) instead of x.y = z on javascript types
  • Created a makefile to generate the examples
  • Set up all the py2js code in a py2js module (executable is now called pyjs.py)
  • Code cleanups

@certik
Copy link
Member

certik commented Mar 7, 2011

Hi,

I run examples and they work. However, the tests fail for me:

$ ./run_tests.py 
Testing the file: tests/test_builtins.js                                    [OK]
Testing the file: tests/test_compile_js.py                                  [OK]
tests/algorithms/sqrt.py [4]: ..                                          [FAIL]

so -1 to this pull request until it is fixed.

@certik
Copy link
Member

certik commented Mar 7, 2011

But otherwise I agree with the changes and thanks for the patch! Let's get the tests fixed and push this in.

@Neppord
Copy link
Contributor

Neppord commented Mar 7, 2011

think the run_tests script is not updated with the new compile script name

@chrivers
Copy link
Author

chrivers commented Mar 7, 2011

You're right, run_tests was missing an update. Everything is working again now, but I'm not sure how to merge the newest commits?

@Neppord
Copy link
Contributor

Neppord commented Mar 7, 2011

merge?
so what you whant to do?
pull qsnake/py2js/master
im not shure i understand....

…ications and libraries that might use run_tests.py
@chrivers
Copy link
Author

chrivers commented Mar 7, 2011

Well Ondrej said we both have push access to qsnake/py2js now, but that non-trivial merges should go through a pull request. I assume there is some way in github to approve the pull request, so the changes will be merged?

Or is this done through git?

@Neppord
Copy link
Contributor

Neppord commented Mar 7, 2011

i think its thrugh git..
ill do it if you whant and then tell you how i didi it ^^. im on mumble rigth now if you like to talk.

@certik
Copy link
Member

certik commented Mar 7, 2011

When you push it in, the pull request closes automatically. The reason to send things through pull requests (even though you have rights to push it in directly) is so that we can review it publicly before it goes in.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants