1337 Atomic value becomes atomic item #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good.
Fair enough (and it’s still correct to call those items values). |
ChristianGruen
approved these changes
Aug 2, 2024
michaelhkay
force-pushed
the
1337-atomic-item
branch
from
4529042 to
68c9b1e
Compare
Arithmeticus
reviewed
Sep 3, 2024
| Don changes (XPathXQuery.xml, introduction.xml, fragment.xml): | ||
| I have attempted to update these files with the latest terminology | ||
| (mainly changing "simple value" to "atomic value" and related changes.) | ||
| (mainly changing "simple value" to "atomic item" and related changes.) |
Contributor
There was a problem hiding this comment.
Stet? This fiddles with a changelog.
Contributor
Author
There was a problem hiding this comment.
I don't know if javacc.xsl was ever updated to support the XPath 3.1 grammar, it certainly hasn't been updated to support 4.0. (I believe it is code to generate a javaCC parser from the EBNF grammar).
michaelhkay
force-pushed
the
1337-atomic-item
branch
from
482c9bf to
01a5838
Compare
michaelhkay
added
the
Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1337
I was half-expecting this change to have repercussions, but in practice it seems very clean.
There are probably more places that should change, e.g. use "xs:boolean item" rather than "xs:boolean value", but we can deal with them as we come to them.