1366 Use ++ and ** operators in EBNF#1498
Merged
ndw merged 4 commits intoqt4cg:masterfrom Oct 29, 2024
Merged
Conversation
michaelhkay
added
Editorial
Contributor
Author
|
Fix #1348 |
ChristianGruen
approved these changes
Oct 16, 2024
ndw
approved these changes
Oct 21, 2024
Contributor
ndw
left a comment
ndw
left a comment
There was a problem hiding this comment.
Looks fine to me, and builds successfully.
Contributor
Author
|
Note that there's a high risk of conflict with any other PR that changes the grammar - will probably need to do some conflict resolution. |
Contributor
|
I was very tempted to merge this one early, so that PR authors could try to resolve that before tomorrow. But then I chickened out in case it introduced a lot of merge conflicts that authors wouldn't have time to fix. |
michaelhkay
force-pushed
the
1366-ebnf-for-separated-sequences
branch
from
de6efaf to
57da5a0
Compare
michaelhkay
added
the
Completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1366