Skip to content

1889 Tidy up handling of HTML serialization version, default to HTML5#1977

Merged
michaelhkay merged 2 commits into
qt4cg:masterfrom
michaelhkay:1889-html-serialization-version
May 13, 2025
Merged

1889 Tidy up handling of HTML serialization version, default to HTML5#1977
michaelhkay merged 2 commits into
qt4cg:masterfrom
michaelhkay:1889-html-serialization-version

Conversation

@michaelhkay
Copy link
Copy Markdown
Contributor

Does some general tidying up of the serialization text, but the main substantive changes are (a) to make HTML5 the default version, and (b) to make support for earlier versions effectively optional.

Please review carefully. Marking as editorial because I'm not sure any test cases need to change, but I might be wrong.

Fix #1889

@michaelhkay michaelhkay added Editorial Minor typos, wording clarifications, example fixes, etc. Serialization An issue related to the Serialization spec labels May 2, 2025
@ChristianGruen
Copy link
Copy Markdown
Contributor

ChristianGruen commented May 5, 2025

I read the changes, and I am not 100% sure if I can answer my second question:

  1. If only version is supplied, is it correct that it is ignored because of html-version defaulting to 5?
(: html-version=5 ? :) 
serialize(<html/>, { 'method': 'html', 'version': '4.01' })

With the latest version of Saxon, it seems that the input is (still?) serialized as 4.01:

<html></html>

@michaelhkay michaelhkay merged commit 901a77f into qt4cg:master May 13, 2025
3 checks passed
@michaelhkay michaelhkay added the Tests Needed Tests need to be written or merged label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Editorial Minor typos, wording clarifications, example fixes, etc. Serialization An issue related to the Serialization spec Tests Needed Tests need to be written or merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML serialization: html-version and version parameters; allowed values

2 participants