Skip to content

Update TSENS thermal zone#615

Open
dmantre wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
dmantre:purwa-highertj
Open

Update TSENS thermal zone#615
dmantre wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
dmantre:purwa-highertj

Conversation

@dmantre
Copy link
Copy Markdown

@dmantre dmantre commented May 26, 2026

Purwa IOT boards support a different thermal junction temperature specification compared to the base Purwa platform due to package level differences.

Update the passive trip thresholds to 105°C to align with the higher temperature specification.

Purwa IOT boards support a different thermal junction temperature
specification compared to the base Purwa platform due to package
level differences.

Update the passive trip thresholds to 105°C to align with the higher
temperature specification.

Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
@dmantre dmantre requested review from a team, Komal-Bajaj, knaveen-qc and quicAspratap May 26, 2026 12:53
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis
Copy link
Copy Markdown

PR #615 — validate-patch

PR: #615

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
  2. Lore link matches PR commits: Cannot verify - network access to lore.kernel.org is blocked; unable to fetch upstream patch for comparison
  3. Upstream patch status: Cannot verify - network restrictions prevent fetching lore thread to check for merge/NAK/pending signals or searching mainline/stable trees
  4. PR present in qcom-next: No - searched qcom-next history for purwa-iot-evk thermal zone updates; no matching commit found (last activity on this file was Bluetooth/camss/UFS/SDC2 changes)

Recommendation for manual review:

  • Verify the lore patch author matches the Signed-off-by: in this commit (FROMLIST rule: original author's SOB must be present)
  • Confirm the diff content is faithful to the lore posting
  • Check lore thread for any review feedback or newer revisions (v2, v3, etc.)
  • Verify upstream acceptance status before merging
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #615 - FROMLIST: arm64: dts: qcom: purwa-iot-evk: Update TSENS thermal zone
Upstream commit: https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
Verdict: ⚠️ PARTIAL (network restrictions prevented full upstream verification)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - network access to lore.kernel.org blocked
Body preserves rationale Clear description of thermal spec difference and 105°C threshold
Fixes tag present/correct N/A Not a bug fix - new thermal configuration
Authorship preserved ⏭️ FROMLIST: submitter in From: is expected; cannot verify lore author's Signed-off-by without upstream fetch
Backport note (if applicable) N/A FROMLIST prefix used correctly for posted-but-not-merged patch

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa-iot-evk.dts Clean addition of 4 thermal zone overrides (thermal_gpuss_0-3), each setting trip-point0 to 105000 (105°C)

Issues

  • Network restriction: Cannot fetch upstream lore patch to verify diff faithfulness, commit message accuracy, or check for newer revisions
  • FROMLIST authorship rule: For FROMLIST commits, the submitter (Gaurav Kohli) is legitimately in From: field. The original lore author's Signed-off-by: must be present in the commit message - cannot verify without fetching the lore patch, but the current commit only has one Signed-off-by: (the submitter's), which suggests either (a) Gaurav is the original author, or (b) the original author's SOB is missing if this was someone else's patch

Verdict

Cannot complete full validation due to network restrictions. The commit structure is well-formed (proper FROMLIST prefix, lore link present, clear rationale), but upstream diff comparison and authorship chain verification require lore.kernel.org access.

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
  2. Lore link matches PR commits: Cannot verify - network access to lore.kernel.org is blocked; unable to fetch upstream patch for comparison
  3. Upstream patch status: Cannot verify - network restrictions prevent fetching lore thread to check for merge/NAK/pending signals or searching mainline/stable trees
  4. PR present in qcom-next: No - searched qcom-next history for purwa-iot-evk thermal zone updates; no matching commit found (last activity on this file was Bluetooth/camss/UFS/SDC2 changes)

Recommendation for manual review:

  • Verify the lore patch author matches the Signed-off-by: in this commit (FROMLIST rule: original author's SOB must be present)
  • Confirm the diff content is faithful to the lore posting
  • Check lore thread for any review feedback or newer revisions (v2, v3, etc.)
  • Verify upstream acceptance status before merging

@qlijarvis
Copy link
Copy Markdown

PR #615 — checker-log-analyzer

PR: #615
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26449268618

Checker Result Summary
Checker Result Summary
checkpatch 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check FATAL: Label or path not found
sparse-check ⏭️ No C/H files changed
check-uapi-headers ⏭️ No C/H files changed
check-patch-compliance FROMLIST prefix + Link present
tag-check Subject has valid FROMLIST: prefix
qcom-next-check ⚠️ FROMLIST commit targeting qcom-6.18.y (not qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #615 - FROMLIST: arm64: dts: qcom: purwa-iot-evk: Update TSENS thermal zone
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26449268618
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check FATAL: Label or path not found
sparse-check ⏭️ No C/H files changed
check-uapi-headers ⏭️ No C/H files changed
check-patch-compliance FROMLIST prefix + Link present
tag-check Subject has valid FROMLIST: prefix
qcom-next-check ⚠️ FROMLIST commit targeting qcom-6.18.y (not qcom-next)

❌ dtb-check — FATAL BUILD ERROR

Root cause: The patch references thermal zone labels (&thermal_gpuss_0, &thermal_gpuss_1, &thermal_gpuss_2, &thermal_gpuss_3) that do not exist in the device tree at the target branch qcom-6.18.y.

Failure details:

Error: ../arch/arm64/boot/dts/qcom/purwa-iot-evk.dts:1332.1-17 Label or path thermal_gpuss_0 not found
Error: ../arch/arm64/boot/dts/qcom/purwa-iot-evk.dts:1340.1-17 Label or path thermal_gpuss_1 not found
Error: ../arch/arm64/boot/dts/qcom/purwa-iot-evk.dts:1348.1-17 Label or path thermal_gpuss_2 not found
Error: ../arch/arm64/boot/dts/qcom/purwa-iot-evk.dts:1356.1-17 Label or path thermal_gpuss_3 not found
FATAL ERROR: Syntax error parsing input tree
make[4]: *** [../scripts/Makefile.dtbs:132: arch/arm64/boot/dts/qcom/purwa-iot-evk.dtb] Error 1

The patch attempts to override thermal zone nodes using phandle references (&thermal_gpuss_0 through &thermal_gpuss_3), but these labels are not defined in the base device tree files included by purwa-iot-evk.dts.

Fix:

Option 1 (Recommended): Ensure the prerequisite patch that defines these thermal zone labels is merged into qcom-6.18.y first, then rebase this PR.

Option 2: If the thermal zones exist but with different label names, update the patch to use the correct labels present in qcom-6.18.y.

Option 3: If the thermal zones don't exist at all in qcom-6.18.y, this patch cannot be applied to this branch. It should either:

  • Target a different branch where the thermal zones are defined, OR
  • Be preceded by a patch series that adds the thermal zone definitions

Reproduce locally:

git checkout qcom-6.18.y
git cherry-pick a68507c5b7f681cb91cf7969db77075fb81b63b9
make -j$(nproc) O=out defconfig
make -j$(nproc) O=out arch/arm64/boot/dts/qcom/purwa-iot-evk.dtb

To investigate which thermal zone labels exist:

git checkout qcom-6.18.y
grep -r "thermal_gpuss" arch/arm64/boot/dts/qcom/

⚠️ qcom-next-check

Observation: This is a FROMLIST: commit (posted upstream at https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com) targeting the qcom-6.18.y branch.

Policy note: FROMLIST: and UPSTREAM: commits typically target qcom-next or qcom-next-staging first, then flow to release branches. Directly targeting a release branch (qcom-6.18.y) with a FROMLIST: commit may indicate:

  • A backport scenario (should use BACKPORT: prefix if modified)
  • A cherry-pick from qcom-next (verify the commit exists there first)
  • An out-of-order merge (the commit should land in qcom-next first)

Recommendation: Verify this commit is already in qcom-next before merging to qcom-6.18.y. If it's a backport with modifications, use the BACKPORT: prefix instead.


Verdict

❌ BLOCKER: Cannot merge — DTB build fails.

The patch references thermal zone labels that do not exist in the qcom-6.18.y branch, causing a fatal device tree compilation error. This must be resolved before the PR can be merged:

  1. Immediate action: Identify why the thermal zone labels are missing in qcom-6.18.y
  2. Resolution path: Either merge the prerequisite patches that define these labels first, or retarget this PR to a branch where the labels exist
  3. Verification: Confirm the DTB builds successfully after the fix

@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants