Add CONTRIBUTING.md with guidelines for testkit repository #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contributing guide provides instructions specific to shell script development, including POSIX compliance, ShellCheck usage, and directory structure expectations. It aligns contributors to common development workflows. Signed-off-by: smuppand <smuppand@qti.qualcomm.com>
Contributor
|
Looks good |
mwasilew
approved these changes
May 12, 2025
Contributor
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
LGTM. I'm not sure whether this needs to wait for Vamsee's changes. Currently scripts use absolute paths and this doc suggests relative paths.
Contributor
Author
Vamsee's changes, which include the relative path, are currently under review. I'll go and merge this changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contributing guide provides instructions specific to shell script development, including POSIX compliance, ShellCheck usage, and directory structure expectations. It aligns contributors to common development workflows.