Skip to content

AudioRecord: PipeWire-first recording with smart fallback and capture helpers added #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

AudioRecord: PipeWire-first recording with smart fallback and capture helpers added #200

merged 2 commits into from
Oct 22, 2025

Conversation

@smuppand
Copy link
Contributor

@smuppand smuppand commented Oct 22, 2025

Why this PR?

  • Use pw-record against PipeWire default when SRC_ID is empty; never skip prematurely.
  • Accept non-trivial output (bytes > 1024) even if rc ≠ 0 to avoid unnecessary fallbacks.
  • Add alsa_pick_virtual_pcm() to pick pipewire → pulse → default via arecord -L.
  • Harden ALSA path: normalize "hw:0 1," → "hw:0,1" and auto-pick a valid capture device.
  • Preserve existing logs/JUnit; resolves RB3 mic detection and prevents spurious retries.

@smuppand
audio_common.sh: backend/mic discovery & capture utilities
4b996ee 
- Introduce ALSA capture utilities:
  - alsa_pick_capture(): pick a valid hw:<card>,<device> using
    with fallbacks to /proc/asound/{pcm,devices}

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
@smuppand
AudioRecord/run.sh: prefer PipeWire default; accept valid audio befor…
64c575f 
…e fallback; smart virtual-PCM fallback

- Do NOT skip when PipeWire is selected but SRC_ID is empty; try
  against the PipeWire default source first
- Immediately accept a recording if the output WAV is non-trivial (bytes > 1024),
  even when pw-record returns a non-zero rc (observed on RB3)

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
@smuppand smuppand requested a review from abbajaj806 October 22, 2025 11:54
abbajaj806
abbajaj806 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit f1674ac into qualcomm-linux:main Oct 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbajaj806 abbajaj806 abbajaj806 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smuppand @abbajaj806