Video V4L2: platform-aware LAVA plan, custom KO_* module sources, Kodiak FW handling, and docs #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend video_find_module_file() to optionally search: - KO_DIRS (colon-separated dirs, bounded depth) - KO_TREE (alt root with lib/modules/) - Honor KO_PREFER_CUSTOM to search custom sources first/last. - Keep legacy order (modinfo → updates → system) and fall back to custom dirs when not preferred-first. - Add video_log_resolve() calls to trace resolution source (modinfo, ko-dir, altroot-tree, updates-tree, system-tree). - ShellCheck fix: replace A && B || continue with an explicit if/continue to avoid SC2015. - No behavior change when KO_* vars are unset. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
- New optional CLI: --ko-dir DIR[:DIR2], --ko-tree ROOT, --ko-tar FILE.tar[.*], --ko-prefer-custom - If --ko-tar is given, extract once into /run/iris_mods/ and auto-wire KO_TREE/KO_DIRS as appropriate (bounded depth). - Print custom module tree/dirs only when provided; no default change. - Preserve existing behavior unless KO_* flags are used. - Keep idempotent init_env sourcing; retain both-pass reexec logic. - Minor logging polish: surface selected platform, app path, and custom-source summary, no functional changes to core test loop. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
- Add documentation for custom module source flags: --ko-dir, --ko-tree, --ko-tar, --ko-prefer-custom. - Explain one-shot tar extraction under /run/iris_mods/ and search order (tree/dirs) with bounded depth. - Clarify use of LAVA-provided secrets for SSID/PASSWORD in jobs. - Expand examples: --stack both, kodiak --downstream-fw usage, app override, and wait/timeout envs. - Refresh “What’s New” and features to include module-source customizations, network debounce, wget tunables, and SKIP-on-offline. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
- Introduce a trimmed, fastrpc-style YAML for the Video V4L2 runner. - Consume Wi-Fi creds strictly via LAVA secrets env (LAVA_WIFI_SSID / LAVA_WIFI_PASSWORD). - Auto-args by platform: - kodiak: set --app and --downstream-fw (+ pass SSID/PASSWORD) - lemans/monaco: pass SSID/PASSWORD; no downstream-fw flag - Run two passes in one job: --stack base then --stack overlay. - Post results via send-to-lava.sh; keep optional result_parse.sh. - No repo-wide env changes; preserves run.sh interfaces. - Backward-compatible with existing device job templates. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR streamlines the Video V4L2 flow end-to-end:
KO_*CLI flags in[run.sh](http://run.sh/), with one-shot tar extraction.[lib_video.sh](http://lib_video.sh/)(supports KO_DIRS/KO_TREE, keeps legacy order, adds trace).All changes are backward-compatible; default behavior is unchanged unless new flags are supplied.
This fixes #203 issue reported by internal users.