Video V4L2: add local clips support (--clips-tar/--clips-dest), keep base clean of custom KOs, and update LAVA job to use local bundle (no Wi-Fi) #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keep base clean - Add opt-in local media bundle handling: - --clips-tar /path/to/video_clips_iris.tar.gz - --clips-dest /path/to/unpack/dir If provided, runner extracts once (best-effort) and uses local clips. - Preserve existing EXTRACT_INPUT_CLIPS semantics; network bring-up only happens when fetch is actually needed and no local bundle is supplied. - Keep “base” (upstream) pass clean of any custom .ko handling; only overlay uses ko args when provided. - Retain Kodiak downstream FW guard (--downstream-fw) and hard-gate stack validation (upstream vs downstream). - No behavior change for existing callers: defaults remain intact. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
…e free of ko args - Stop relying on Wi-Fi/LAVA secrets for clip fetch; pass local bundle: CLIPS_TAR=/data/vendor/iris_test_app/video_clips_iris.tar.gz CLIPS_DEST=/data/vendor/iris_test_app/clips - Invoke run.sh twice: - BASE (upstream): add only --clips-* (no ko options) - OVERLAY (downstream): add --clips-* plus --ko-dir and --ko-prefer-custom - On Kodiak overlay, include --downstream-fw to satisfy FW requirement. - Keep platform flag conditional (kodiak|lemans|monaco) with autodetect fallback. - Preserve result shipping via send-to-lava.sh and optional roll-up. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the Video_V4L2 runner self-sufficient with local media bundles and
ensures the upstream “base” pass remains clean (no custom .ko), while the
“overlay” pass can opt into downstream modules. The LAVA job is updated to use a
local clips tarball instead of Wi-Fi secrets/network fetches.
What’s changed
Runner (run.sh)
--clips-tar /path/to/video_clips_iris.tar.gz--clips-dest /path/to/unpack/dirThe bundle is extracted once (best-effort) and used for test inputs.
EXTRACT_INPUT_CLIPSsemantics:--clips-taris provided, we do not trigger network fetch.EXTRACT_INPUT_CLIPS=true, we fall back to fetch (existing behavior)..koarguments are used in the base pass.--ko-dir/--ko-tree/--ko-tar --ko-prefer-custom.--downstream-fw(unchanged hard-gate).LAVA job (Video_V4L2_With_Secrets.yaml)
CLIPS_TAR=/data/vendor/iris_test_app/video_clips_iris.tar.gzCLIPS_DEST=/data/vendor/iris_test_app/clips--clips-*(no KO flags).--clips-*+--ko-dir /data/vendor/iris_test_app --ko-prefer-custom.--downstream-fw /data/vendor/iris_test_app/vpu20_p1_gen2.mbn.utils/[send-to-lava.sh](http://send-to-lava.sh/)and optional roll-up.Usage examples
Base (upstream), local clips only: