From dc50b050463e23e4d84c505ff1ae27360ad33b27 Mon Sep 17 00:00:00 2001 From: Viswanath Kraleti Date: Wed, 12 Nov 2025 11:18:53 +0530 Subject: [PATCH 1/2] gen_partition.py: rename functions for clarity MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Renamed functions to better reflect their purpose: - `generate_ptool_xml` → `generate_single_disk_xml` - `generate_ufs_xml` → `generate_multi_lun_xml` - `generate_nand_mbn_gen_xml` → Dropped as unused These changes have no functional impact. Signed-off-by: Viswanath Kraleti --- gen_partition.py | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/gen_partition.py b/gen_partition.py index 3990a07..35565c7 100755 --- a/gen_partition.py +++ b/gen_partition.py @@ -151,8 +151,7 @@ def parse_disk_entry(disk_entry): print (str(e)) usage() -def generate_ptool_xml (disk_params, partition_entries_dict, output_xml): - print("Generating ptool XML %s" %(output_xml)) +def generate_single_disk_xml (disk_params, partition_entries_dict, output_xml): root = ET.Element("configuration") parser_instruction_text = "" @@ -174,8 +173,7 @@ def generate_ptool_xml (disk_params, partition_entries_dict, output_xml): with open(output_xml, "w") as f: f.write(xmlstr) -def generate_ufs_xml (disk_params, partition_entries_dict, output_xml): - print("Generating UFS XML %s" %(output_xml)) +def generate_multi_lun_xml (disk_params, partition_entries_dict, output_xml): root = ET.Element("configuration") parser_instruction_text = "" @@ -206,18 +204,15 @@ def generate_ufs_xml (disk_params, partition_entries_dict, output_xml): with open(output_xml, "w") as f: f.write(xmlstr) - -def generate_nand_mbn_gen_xml (disk_params, partition_entry): - print("Generating nand_mbn_gen XML") - def generate_partition_xml (disk_entry, partition_entries_dict, output_xml): parse_disk_entry(disk_entry) + print("Generating %s XML %s" %(disk_params["type"].upper(), output_xml)) if disk_params["type"] == "emmc": - generate_ptool_xml(disk_params, partition_entries_dict, output_xml) - elif disk_params["type"] == "nand": - generate_nand_mbn_gen_xml(disk_params, partition_entries_dict, output_xml) + generate_single_disk_xml(disk_params, partition_entries_dict, output_xml) elif disk_params["type"] == "ufs": - generate_ufs_xml(disk_params, partition_entries_dict, output_xml) + generate_multi_lun_xml(disk_params, partition_entries_dict, output_xml) + else: + print("%s XML generation is curently not supported." %(disk_params["type"].upper())) ############################################################################### # main From d8810ff015b6eb14d9eff9a842cc8cf235c4593c Mon Sep 17 00:00:00 2001 From: Viswanath Kraleti Date: Wed, 12 Nov 2025 11:23:06 +0530 Subject: [PATCH 2/2] gen_partition.py: add NVMe as a valid disk type NVMe flashing follows the same process as eMMC. Add `nvme` as a valid disk type to explicitly call out the supported storage options. Signed-off-by: Viswanath Kraleti --- gen_partition.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gen_partition.py b/gen_partition.py index 35565c7..cbbf7b7 100755 --- a/gen_partition.py +++ b/gen_partition.py @@ -207,7 +207,7 @@ def generate_multi_lun_xml (disk_params, partition_entries_dict, output_xml): def generate_partition_xml (disk_entry, partition_entries_dict, output_xml): parse_disk_entry(disk_entry) print("Generating %s XML %s" %(disk_params["type"].upper(), output_xml)) - if disk_params["type"] == "emmc": + if disk_params["type"] in ("emmc", "nvme"): generate_single_disk_xml(disk_params, partition_entries_dict, output_xml) elif disk_params["type"] == "ufs": generate_multi_lun_xml(disk_params, partition_entries_dict, output_xml)