Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-targeting (NET Standard 2.0 + NET Framework 4.5) #15

Closed
vslee opened this issue Apr 26, 2020 · 0 comments · Fixed by #36
Closed

Multi-targeting (NET Standard 2.0 + NET Framework 4.5) #15

vslee opened this issue Apr 26, 2020 · 0 comments · Fixed by #36

Comments

@vslee
Copy link
Contributor

vslee commented Apr 26, 2020 •
edited

Currently, IBAutomater only targets NET Framework 4.5. Would it be possible to support multi-targeting, so that it can be used from NET Standard projects as well?

  1. The first step is that the .csproj would need to be modified to use be a SDK-style project instead of a MSBuild one. (PR changed QuantConnect.IBAutomater.csproj to SDK style #16 merged)
  2. After that's done, then the .csproj can be changed from targeting net452 to netstandard20
vslee added a commit to vslee/IBAutomater that referenced this issue May 11, 2020
@vslee
changed QuantConnect.IBAutomater.csproj to SDK style
df865c8 
- it was previously MSBuild style
- this changes it to the newer SDK style, which will allow further options in the future
- SDK style is more concise: a lot of settings which were explicitly specified before are now the defaults
- functional settings have been preserved, including targeting .net framework 4.5.2, as well as Newtonsoft.Json 10.0.3
- App.Config, packages.config, and AssemblyInfo.cs were able to be removed as their information is now in QuantConnect.IBAutomater.csproj
- NuGet settings have not been touched
- part of QuantConnect#15
@vslee vslee mentioned this issue May 11, 2020
Merged
@vslee vslee mentioned this issue Dec 20, 2020
Closed
@vslee vslee mentioned this issue Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@vslee