Dfm attribute "smooth" is not set by dfm_smooth

[chmue]

The class documentation for dfm describes a smooth slot which holds the value of smoothed feature counts. As far as I understand, this value should be changed by dfm_smooth and dfm_weight if any smoothing is done. At the moment, neither function actually changes it.

[chmue]

I'm tracking this in the issue-1274 branch.

[chmue]

Do you want to set the smooth slot in cases where you "smooth" by flooring logarithms at 0 as well?

E.g. in the following case (from here)

} else if (scheme == "logcount") {
  x@x <- 1 + log(x@x, base)
  x@x[is.infinite(x@x)] <- 0

one could argue that the amount of "smoothing" is base^(-1) or exp(-1) in the default case. However, it is not really smoothing as in dfm_smooth() as it the smoothing values is only added to the counts that are zero and not all the counts.

What do you think @kbenoit ?

[kbenoit]

No, the smooth parameter is just for a constant added via dfm_smooth().