function can't work

[wulixin]

Describe the bug

the dfm_select and dfm_sample , that the arguements are usefuless ,can't work
Please describe what the bug is.

Reproducible code

Please paste minimal code that reproduces the bug. If possible, please upload the data file as .rds.

# paste here #
dfm_sample(x,what=c("documents","features"))

Expected behavior

Please explain what you expected to happen.

## System information

Please run sessionInfo() and paste the output.

sessionInfo() 
#result 
version 3.5.2 (2018-12-20)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)

Matrix products: default

locale:
[1] LC_COLLATE=Chinese (Simplified)_China.936 
[2] LC_CTYPE=Chinese (Simplified)_China.936   
[3] LC_MONETARY=Chinese (Simplified)_China.936
[4] LC_NUMERIC=C                              
[5] LC_TIME=Chinese (Simplified)_China.936    

attached base packages:
[1] stats     graphics  grDevices utils     datasets 
[6] methods   base     

other attached packages:
[1] ggplot2_3.1.0  dplyr_0.8.0.1  igraph_1.2.4  
[4] quanteda_1.4.1

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.0                 sna_2.4                   
 [3] RColorBrewer_1.1-2         pillar_1.3.1              
 [5] compiler_3.5.2             plyr_1.8.4                
 [7] iterators_1.0.10           xts_0.11-2                
 [9] tools_3.5.2                stopwords_0.9.0           
[11] digest_0.6.18              lubridate_1.7.4           
[13] tibble_2.0.1               gtable_0.2.0              
[15] lattice_0.20-38            pkgconfig_2.0.2           
[17] rlang_0.3.1                Matrix_1.2-15             
[19] foreach_1.4.4              fastmatch_1.1-0           
[21] rstudioapi_0.9.0           ggrepel_0.8.0             
[23] yaml_2.2.0                 coda_0.19-2               
[25] withr_2.1.2                stringr_1.4.0             
[27] PortfolioAnalytics_1.1.0   grid_3.5.2                
[29] tidyselect_0.2.5           glue_1.3.0                
[31] data.table_1.12.0          R6_2.4.0                  
[33] reshape2_1.4.3             purrr_0.3.0               
[35] spacyr_1.0                 magrittr_1.5              
[37] ISOcodes_2019.02.13        scales_1.0.0              
[39] codetools_0.2-15           PerformanceAnalytics_1.5.2
[41] assertthat_0.2.0           colorspace_1.4-0          
[43] labeling_0.3               quadprog_1.5-5            
[45] stringi_1.3.1              network_1.14-377          
[47] lazyeval_0.2.1             RcppParallel_4.4.2        
[49] munsell_0.5.0              statnet.common_4.2.0      
[51] crayon_1.3.4               zoo_1.8-4 

Additional info

Please add any other information about the issue.
Error in dfm_sample(x, what = c("documents", "features")) :
unused argument (what = c("documents", "features"))

[kbenoit]

@wulixin That does not describe the bug in any way. What is the error you experienced?

@koheiw I did notice that the size default is wrong when margin = "features".

library("quanteda", warn.conflicts = FALSE)
## Package version: 1.3.14
## Parallel computing: 2 of 12 threads used.
## See https://quanteda.io for tutorials and examples.

dfmat <- dfm(c("a b c c d", "a a c c d d d"))

set.seed(100)
dfm_sample(dfmat, margin = "documents", replace = TRUE)
## Document-feature matrix of: 2 documents, 4 features (0.0% sparse).
## 2 x 4 sparse Matrix of class "dfm"
##        features
## docs    a b c d
##   text1 1 1 2 1
##   text1 1 1 2 1
dfm_sample(dfmat, margin = "features", replace = TRUE)
## Document-feature matrix of: 2 documents, 2 features (0.0% sparse).
## 2 x 2 sparse Matrix of class "dfm"
##        features
## docs    c a
##   text1 2 1
##   text2 2 2
dfm_sample(dfmat, size = nfeat(dfmat), margin = "features", replace = TRUE)
## Document-feature matrix of: 2 documents, 4 features (37.5% sparse).
## 2 x 4 sparse Matrix of class "dfm"
##        features
## docs    b b d b
##   text1 1 1 1 1
##   text2 0 0 3 0

Probably it should be:

dfm_sample(x, size = ifelse(margin == "documents", ndoc(x), nfeat(x)), 
           replace = FALSE, prob = NULL, margin = c("documents", "features"))