Ensure dfm_lookup returns dfm with all the keys#1946
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1946 +/- ##
==========================================
- Coverage 91.27% 91.26% -0.02%
==========================================
Files 100 100
Lines 6318 6319 +1
==========================================
Hits 5767 5767
- Misses 551 552 +1 |
kbenoit
reviewed
May 11, 2020
kbenoit
approved these changes
May 11, 2020
kbenoit
left a comment
Collaborator
There was a problem hiding this comment.
Interestingly I noticed this too today, when working on the sentiment branch!
Collaborator
Author
|
I noticed this today when I was working on #1912 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major bug.
dfm_lookup()returns a dfm without columns when there is no matches.