Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ngrams argument examples from dfm help #2005

Merged
merged 3 commits into from Nov 11, 2020
Merged

Remove ngrams argument examples from dfm help #2005

merged 3 commits into from Nov 11, 2020

Conversation

kbenoit
Copy link
Collaborator

@kbenoit kbenoit commented Nov 9, 2020

Removes the examples from the dfm help that still contain the ngrams argument, despite this being removed many versions ago.

Solves #1990
Closes #1896

See also #1602

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #2005 (38100b3) into master (9182963) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2005   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         102      102           
  Lines        6512     6512           
=======================================
  Hits         5871     5871           
  Misses        641      641           
Impacted Files Coverage Δ
R/dfm.R 98.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9182963...38100b3. Read the comment docs.

@kbenoit kbenoit requested a review from koheiw November 10, 2020 08:53
@kbenoit kbenoit merged commit 96478db into master Nov 11, 2020
@kbenoit kbenoit deleted the fix-1990 branch November 11, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ngrams back to dfm()?
2 participants