Fixes for deprecated Matrix calls and for forthcoming Matrix 1.4-2#2182
Merged
Conversation
Collaborator
Author
|
Tests above are failing but it does pass cleanly with Matrix 1.4-2. I need to test more with current CRAN release of Matrix too. |
koheiw
reviewed
Aug 26, 2022
koheiw
reviewed
Aug 26, 2022
koheiw
reviewed
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #2182 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 87 87
Lines 5099 5100 +1
=======================================
+ Hits 4917 4918 +1
Misses 182 182
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
koheiw
reviewed
Aug 27, 2022
added 4 commits
August 28, 2022 10:35
Did this since it seems to fail in the PR checks build, and since I have a local check for this anyway (on my local machine).
koheiw
reviewed
Aug 28, 2022
koheiw
reviewed
Aug 28, 2022
koheiw
reviewed
Aug 28, 2022
koheiw
reviewed
Aug 28, 2022
koheiw
reviewed
Aug 28, 2022
koheiw
reviewed
Aug 28, 2022
koheiw
approved these changes
Aug 28, 2022
Collaborator
koheiw
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for your work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as()calls (mostlyas(., "dgCMatrix")which we'd used a lot)options(Matrix.warnDeprecatedCoerce = 2)intestthat.R