Skip to content

Avoid segfault error when patterns have paddings in v3.3#2254

Merged
koheiw merged 2 commits into
v3_3from
fix-compound_v3
Apr 14, 2023
Merged

Avoid segfault error when patterns have paddings in v3.3#2254
koheiw merged 2 commits into
v3_3from
fix-compound_v3

Conversation

@koheiw

@koheiw koheiw commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

We should update the v3.3 because it leads to a nasty crash.

@koheiw
koheiw requested a review from kbenoit April 14, 2023 08:35
@koheiw koheiw changed the title Avoid sefault error when patterns has paddings Avoid segfault error when patterns has paddings Apr 14, 2023
@koheiw koheiw changed the title Avoid segfault error when patterns has paddings Avoid segfault error when patterns have paddings Apr 14, 2023
@koheiw koheiw changed the title Avoid segfault error when patterns have paddings Avoid segfault error when patterns have paddings in v3.3 Apr 14, 2023
@kbenoit

kbenoit commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

Oh that's not good. Thanks for finding and fixing it.
I introduced a slight namespace issue myself in the effort to fix one of our conflicts introduced with changing the docvars() generic. I'll submit an update tomorrow.

@koheiw
koheiw merged commit b419c7e into v3_3 Apr 14, 2023
@kbenoit
kbenoit deleted the fix-compound_v3 branch May 7, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants