Conversation
kbenoit
left a comment
There was a problem hiding this comment.
Ah... that's a somewhat radical change. Makes it especially hard to distinguish tokens that contain spaces. What if we added this as an option, with the default to keep the quotes?
|
I agree that tokens should be quoted by default but it is nice to think how to make it easier to read. For example, Not urgent, though... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2381 +/- ##
==========================================
- Coverage 96.18% 96.17% -0.01%
==========================================
Files 94 94
Lines 5892 5890 -2
==========================================
- Hits 5667 5665 -2
Misses 225 225 ☔ View full report in Codecov by Sentry. |
kbenoit
left a comment
There was a problem hiding this comment.
This is pretty innocuous and only turns on if people want it to. We could add a global option print_tokens_quote and set it to TRUE for the default behaviour. Or, just leave it as you have here.
Pass
print.tokens(...)tobase::print()to hide quotes around tokens. I think it is easier to read without quotes.Ideally, there is a option to print (or coerce) like this. But I don't know what is the best way.