Skip to content

Dev tokens trim - #2419

Merged
kbenoit merged 13 commits into
masterfrom
dev-tokens_trim
Aug 30, 2024
Merged

Dev tokens trim#2419
kbenoit merged 13 commits into
masterfrom
dev-tokens_trim

Conversation

@koheiw

@koheiw koheiw commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

For #2402, but tokens_trim() and dfm_trim() do not print verbose messages, because they should be added later in #2396.

I think the sparsity argument should be deprecated as it is the same as min_docfreq where docfreq_type = "prop".

@codecov

codecov Bot commented Aug 26, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.26%. Comparing base (2d2f5dd) to head (f54d3b2).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
R/dfm_trim.R 96.87% 1 Missing ⚠️
R/tokens_trim.R 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2419      +/-   ##
==========================================
+ Coverage   96.22%   96.26%   +0.03%     
==========================================
  Files          94       95       +1     
  Lines        5909     5918       +9     
==========================================
+ Hits         5686     5697      +11     
+ Misses        223      221       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koheiw
koheiw requested a review from kbenoit August 26, 2024 20:56
@kbenoit
kbenoit merged commit 761da7f into master Aug 30, 2024
@kbenoit
kbenoit deleted the dev-tokens_trim branch August 30, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants