Fix max load factor2 - #853
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
==========================================
- Coverage 77.39% 77.38% -0.02%
==========================================
Files 103 103
Lines 7787 7782 -5
==========================================
- Hits 6027 6022 -5
Misses 1760 1760 |
Collaborator
|
On Windows I'm still getting * checking compiled code ... NOTE
File 'quanteda/libs/x64/quanteda.dll':
Found no calls to: 'R_registerRoutines', 'R_useDynamicSymbols'
It is good practice to register native routines and to disable symbol
search.
See 'Writing portable packages' in the 'Writing R Extensions' manual.Can you make sure all functions are registered in |
kbenoit
approved these changes
Jul 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize hash tables by setting max_load_factor in C++. In some cases, hash table construction becomes 10x faster, making lead time of
tokens_*()much shorter.