Python3 compat #47
Python3 compat #47
Conversation
qdb/server/session_store.py
Outdated
| @@ -285,7 +286,7 @@ def _send_to_socket(sck, msg): | |||
| send_to_tracer method. | |||
| """ | |||
| sck.sendall(pack('>i', len(msg))) | |||
| sck.sendall(msg) | |||
| sck.sendall(str_to_bytes(msg, encoding='utf-8')) | |||
There was a problem hiding this comment.
I think we need to convert to bytes before computing length above. This would fail if we wrote any non-unicode data.
There was a problem hiding this comment.
Though, this is also a case where bytes really feels like the right interface to me. "put something into socket" is definitely an operation that only makes sense for bytes. What do you think about lifting the bytes conversion into fmt_msg and fmt_error_msg, since those are already concerned with serialization of the messages we're going to put on the wire?
There was a problem hiding this comment.
Makes sense, but it's a bigger change than I want to make right now. It looks like fmt_msg is used elsewhere (like with bound_cmd_manager in tracer.py) and can take an optional serial parameter. I'd want to spend time digging through all that.
There was a problem hiding this comment.
Ah, yeah, I didn't realized that was used elsewhere. I guess this is fine for now. Can we document explicitly that this takes str (and thus that it expects unicode in py3)?
jbredeche
force-pushed
the
py3-compat
branch
from
9871365
to
ba42bda
Compare
jbredeche
force-pushed
the
py3-compat
branch
from
24c37a1
to
d65efbf
Compare
No description provided.