Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: rename variables to simplify. #1022

Merged
merged 2 commits into from Mar 3, 2016
Merged

MAINT: rename variables to simplify. #1022

merged 2 commits into from Mar 3, 2016

Conversation

@mtydykov
Copy link
Contributor

@mtydykov mtydykov commented Mar 1, 2016

Some of the variables related to buyback auth are unnecessarily long; this PR simplifies them.

@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented Mar 2, 2016

LGTM. Does this depend on downstream changes before merge?

@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented Mar 2, 2016

Also, do we have a whatsnew entry for the BuybackAuth dataset?

@mtydykov
Copy link
Contributor Author

@mtydykov mtydykov commented Mar 2, 2016

Don't think anything downstream needs to change. Should I add the entry to 0.8.4.txt?

Maya Tydykov added 2 commits Mar 1, 2016
@mtydykov mtydykov force-pushed the better_buybackauth_names branch from 7ea469c to 0010828 Mar 3, 2016
mtydykov pushed a commit that referenced this pull request Mar 3, 2016
MAINT: rename variables to simplify.
@mtydykov mtydykov merged commit c183058 into master Mar 3, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mtydykov mtydykov deleted the better_buybackauth_names branch Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.