New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: add dividends datasets to inits #1093

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
3 participants
@mtydykov
Contributor

mtydykov commented Mar 29, 2016

Adds dividends data/loaders to inits.

DividendsByAnnouncementDate,
DividendsByExDate
)
from zipline.pipeline.data.earnings import EarningsCalendar
from zipline.pipeline.data import EarningsCalendar

This comment has been minimized.

@llllllllll

llllllllll Mar 29, 2016

Member

All three of these groups should now be merged

DividendsByExDate,
DividendsByAnnouncementDate,
DividendsByPayDate
)
from zipline.pipeline.loaders.dividends import (
from ...loaders import (

This comment has been minimized.

@llllllllll

llllllllll Mar 29, 2016

Member

I think that two levels up should be the max for relative imports, after that I think it stops helping the readability.

This comment has been minimized.

@mtydykov

mtydykov Mar 29, 2016

Contributor

Should we go back to the way it was before for these, then?

@coveralls

This comment has been minimized.

coveralls commented Mar 29, 2016

Coverage Status

Coverage increased (+0.05%) to 88.863% when pulling 84171a5 on finish-dividends-in-pipeline into 9b27f34 on master.

MAINT: add dividends datasets to inits
DOC: add whatsnew entries

@mtydykov mtydykov force-pushed the finish-dividends-in-pipeline branch from daaa200 to d7a012a Mar 29, 2016

@coveralls

This comment has been minimized.

coveralls commented Mar 29, 2016

Coverage Status

Coverage increased (+0.002%) to 88.861% when pulling d7a012a on finish-dividends-in-pipeline into 6a24731 on master.

@coveralls

This comment has been minimized.

coveralls commented Mar 29, 2016

Coverage Status

Coverage increased (+0.002%) to 88.861% when pulling d7a012a on finish-dividends-in-pipeline into 6a24731 on master.

@mtydykov mtydykov merged commit 3b71111 into master Mar 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtydykov mtydykov deleted the finish-dividends-in-pipeline branch Mar 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment