Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BollingerBands factor #1199

Merged
merged 12 commits into from May 13, 2016
Merged

BollingerBands factor #1199

merged 12 commits into from May 13, 2016

Conversation

@llllllllll
Copy link
Contributor

@llllllllll llllllllll commented May 12, 2016

No description provided.

Adds test coverage for the caes where it is not hashable.
from zipline.testing.predicates import assert_equal


_meta = type('_', (type(ZiplineTestCase), ABCMeta), {})

This comment has been minimized.

@richafrank

richafrank May 12, 2016
Member

Since there's nothing dynamic to the type creation here, do you think it would be clearer as

class ZiplineABCMeta(type(ZiplineTestCase), ABCMeta):
    pass
@llllllllll llllllllll force-pushed the boybands-factor branch from 97954a0 to 0229c11 May 12, 2016
@coveralls
Copy link

@coveralls coveralls commented May 12, 2016

Coverage Status

Coverage increased (+0.05%) to 81.514% when pulling 0229c11 on boybands-factor into 8fdbfb8 on master.

@llllllllll llllllllll force-pushed the boybands-factor branch from 0229c11 to c128b69 May 13, 2016
@coveralls
Copy link

@coveralls coveralls commented May 13, 2016

Coverage Status

Coverage increased (+0.05%) to 81.514% when pulling c128b69 on boybands-factor into 8fdbfb8 on master.

@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented May 13, 2016

LGTM

@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented May 13, 2016

wanna add a whatsnew for boy bands?

@llllllllll llllllllll merged commit 784d5f4 into master May 13, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@llllllllll llllllllll deleted the boybands-factor branch May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.