New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fixes reading and writing of daily bars first_trading_day attr #1245

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
2 participants
@yankees714
Contributor

yankees714 commented Jun 2, 2016

When writing 'first_trading_day', it is already in the correct frame of reference (seconds since epoch) and does not need to be transformed further. Adjusts the reader to expect this value.

BUG: Fixes reading and writing of daily bars first_trading_day attr
When writing first_trading_day, it is already in the correct frame of
reference (seconds since epoch) and does not need to be transformed
further. Adjusts the reader to expect this value.
@ehebert

This comment has been minimized.

Member

ehebert commented Jun 2, 2016

/signoff

@yankees714 yankees714 merged commit 1cf8e46 into master Jun 2, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yankees714 yankees714 deleted the daily-bars-first-day-attr branch Jun 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment