New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created dockerfile for zipline dev #1254

Merged
merged 1 commit into from Jun 7, 2016

Conversation

Projects
None yet
4 participants
@ChrisPappalardo
Contributor

ChrisPappalardo commented Jun 3, 2016

No description provided.

@coveralls

This comment has been minimized.

coveralls commented Jun 3, 2016

Coverage Status

Coverage remained the same at 81.848% when pulling a1fdf10 on ChrisPappalardo:dockerfile_cap into 1f327f5 on quantopian:master.

@ssanderson ssanderson self-assigned this Jun 3, 2016

ADD . /zipline
WORKDIR /zipline
RUN pip install -r etc/requirements_dev.txt
RUN pip install datashape

This comment has been minimized.

@ssanderson

ssanderson Jun 3, 2016

Member

We probably want to do pip install -r etc/requirements_blaze.txt so that we get the needed version.

This comment has been minimized.

@ssanderson

ssanderson Jun 3, 2016

Member

(We can do that in one command as pip install -r <file1> -r <file2>.)

#
FROM quantopian/zipline

ADD . /zipline

This comment has been minimized.

@ssanderson

ssanderson Jun 3, 2016

Member

We're already adding . in the root directory. I don't think we need this.

#
# Dockerfile for an image with the currently checked out version of zipline installed. To build:
#
# docker build -t quantopian/ziplinedev .

This comment has been minimized.

@richafrank

richafrank Jun 3, 2016

Member

I think this command needs to specify this dockerfile explicitly, since it's not named just Dockerfile. e.g.

docker build -t quantopian/ziplinedev -f Dockerfile-dev
#
# Dockerfile for an image with the currently checked out version of zipline installed. To build:
#
# docker build -t quantopian/ziplinedev -f quantopian/ziplinedev .

This comment has been minimized.

@richafrank

richafrank Jun 6, 2016

Member

Almost there...

$ docker build -t quantopian/ziplinedev -f quantopian/ziplinedev .
Cannot locate Dockerfile: quantopian/ziplinedev

Looks like we're using the image name instead of the file name:

$ docker build -t quantopian/ziplinedev -f ./Dockerfile-dev .
Sending build context to Docker daemon 
Step 0 : FROM python:2.7
...

Mind just fixing that up, and we'll get this merged? Thanks so much!

This comment has been minimized.

@ChrisPappalardo

ChrisPappalardo Jun 6, 2016

Contributor

Sure I'll get it done today

Sent from my iPhone

On Jun 6, 2016, at 4:29 PM, Richard Frank notifications@github.com wrote:

In Dockerfile-dev:

@@ -0,0 +1,26 @@
+#
+# Dockerfile for an image with the currently checked out version of zipline installed. To build:
+#
+# docker build -t quantopian/ziplinedev -f quantopian/ziplinedev .
Almost there...

$ docker build -t quantopian/ziplinedev -f quantopian/ziplinedev .
Cannot locate Dockerfile: quantopian/ziplinedev
Looks like we're using the image name instead of the file name:

$ docker build -t quantopian/ziplinedev -f ./Dockerfile-dev .
Sending build context to Docker daemon
Step 0 : FROM python:2.7
...
Mind just fixing that up, and we'll get this merged? Thanks so much!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@richafrank

This comment has been minimized.

Member

richafrank commented Jun 7, 2016

@ChrisPappalardo When you clean it up, would you squash the commits and add "DEV: " to the commit message? We're trying to be consistent in our commit messages by using prefixes. Much appreciated.

@ChrisPappalardo

This comment has been minimized.

Contributor

ChrisPappalardo commented Jun 7, 2016

@richafrank sorry it took so long, ive never rebased before and had to figure out how to squash commits that were already pushed to the repo. i think we're good - let me know if i need to make any other changes

@coveralls

This comment has been minimized.

coveralls commented Jun 7, 2016

Coverage Status

Coverage remained the same at 82.75% when pulling 7e70f8f on ChrisPappalardo:dockerfile_cap into fd57705 on quantopian:master.

@richafrank

This comment has been minimized.

Member

richafrank commented Jun 7, 2016

No worries! Thanks for figuring that out. It looks great to me.

@richafrank richafrank merged commit 7879065 into quantopian:master Jun 7, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment